Small AIP-2 updates #1056
Small AIP-2 updates #1056
Conversation
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
…c classes Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1056 +/- ##
==========================================
- Coverage 99.37% 99.33% -0.04%
==========================================
Files 374 374
Lines 21603 21591 -12
==========================================
- Hits 21467 21447 -20
- Misses 136 144 +8 |
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
aip-v2-flag
branch
from
033d982 to
e9403a9
Compare
| pubkey | ||
| ) in pubkeys: # include all public keys, authentication pubkeys by reference | ||
| pubkey_type = PublicKeyType.get(pubkey["type"]) | ||
| key = PublicKey( # initialization canonicalizes id |
There was a problem hiding this comment.
could lose the comment now: it is an orphan
| return ref | ||
|
|
||
| return "did:sov:{}{}{}".format(did, delimiter if delimiter else "#", ref) # e.g., 3 | ||
| return "{}{}{}".format(did, delimiter if delimiter else "#", ref) |
There was a problem hiding this comment.
return f"{did}{delimiter or '#'}{ref}" is slightly briefer but it is not so important
|
Indeed, there is some overlap here with #1033. We're aiming for a more "complete" solution that makes it easy to work with DIDs of various methods and DID Documents in various formats; there will be some code conflicts to resolve but I think the Document version distinction introduced in this PR maps well onto our goals. Especially if this PR is already ready to go, I think merging this PR now (or when ready) and incorporating/superseding the changes with #1033 is probably the way to go. |
Signed-off-by: Andrew Whitehead <[email protected]>
| @@ -194,7 +194,7 @@ class IndyDID(Regexp): | |||
| """Validate value against indy DID.""" | |||
|
|
|||
| EXAMPLE = "WgWxqztrNooG92RXvxSTWv" | |||
| PATTERN = rf"^(did:sov:)?[{B58}]{{21,22}}$" | |||
| PATTERN = rf"^(did:sov:|did:peer:)?[{B58}]{{21,22}}$" | |||
There was a problem hiding this comment.
https://identity.foundation/peer-did-method-spec/index.html#matching-regex
Not sure whether indy-sdk would take these though
There was a problem hiding this comment.
but note that it's bad regex; the trailing $) characters appear twice. Better:
^did:peer:[01](z)([1-9a-km-zA-HJ-NP-Z]{46,47})$
--emit-new-didcomm-prefixand--emit-new-didcomm-mime-typein favour of--aip-version(1 or 2). I believe the .NET framework will currently only accept the old MIME type.did-communicationwhen using thedid-exchangeprotocol.idproperty.did:peer:(does NOT yet qualify other DIDs withdid:sov:).INDY_DIDpattern to acceptdid:sov:ordid:peer:, which isn't technically correct. We should be using a generic DID pattern in most places.did-exchangeprotocol, the new format (withverificationMethod) is used for serialization regardless of the AIP version setting. When using theconnectionsprotocol, the old format (withpublicKey) is used.These changes might be better addressed though the generic resolver PR depending on the timeline, but this is for testing compatibility with other agents.