Display pres req link for debugging #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
loneil
force-pushed
the
feature/presReqLinkDebugging
branch
from
ee0fa86 to
7758c18
Compare
|
There is another issue (#413 ) that requires we add a deep link button to the VC-Authn-OIDC. That ticket should be a very high priority. This implements a lot of it and happy to merge it, but please take a look and carry out that issue. |
|
#413 is in progress |
jamshale
reviewed
Feb 15, 2024
| @@ -88,7 +88,7 @@ export default function getRouter(basePath = '/') { | |||
| document.title = to.meta.title | |||
| ? to.meta.title | |||
| : process.env.VUE_APP_TITLE; | |||
| } else document.title = 'Demo VC-Authn-OIDC App”'; // default title | |||
There was a problem hiding this comment.
Think I did this a long time ago :/
jamshale
approved these changes
Feb 15, 2024
esune
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is not related to BC Wallet deep link feature upcoming)
It's onerous to debug the QR code link on a VCAuth login. Have to snip code out, save, upload to a qr decode or something like that. Would be good to just see the pure text link that's converted to the QR Code.
Can use this to debug locally, or if needed do operational support for a user that's having an issue with the QR code.
Add an easter egg (BC Wallet style, tap 10 times on the BC Gov logo) that exposes the link in a textbox