Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep Link button on QR code page #413

Closed
esune opened this issue Feb 8, 2024 · 4 comments
Closed

Deep Link button on QR code page #413

esune opened this issue Feb 8, 2024 · 4 comments
Assignees

Comments

@esune
Copy link
Member

esune commented Feb 8, 2024

We need a deep-link button below the QR Code to allow same-device authentication.
The deep link should be in the format bcwallet://aries_proof-request?_oob=...

The page could be responsive and hide the QR code when displayed in a mobile device with a screen below a certain size (when viewed in a tablet it might be because it is being used as a replacement for a computer).

@esune esune moved this to Assignment Ready in CDT Enterprise Apps Feb 8, 2024
@esune esune moved this from Assignment Ready to Assigned in CDT Enterprise Apps Feb 9, 2024
@loneil loneil moved this from Assigned to In Progress in CDT Enterprise Apps Feb 15, 2024
@loneil
Copy link
Contributor

loneil commented Feb 15, 2024

@esune wallet OOB handling issue we discussed laid out here

bcgov/bc-wallet-mobile#953 (comment)

@knguyenBC
Copy link

knguyenBC commented Feb 15, 2024

I did some quick wireframes to help improve the UI of the screen based off of recent user research. This is suggested from a UX /UI perspective. https://xd.adobe.com/view/b40869d2-5fff-40ff-855c-ace0d1da0c30-e15b/ explanation of design choices in the comments.

@loneil
Copy link
Contributor

loneil commented Feb 15, 2024

Excellent! Thanks so much @knguyenBC

@loneil
Copy link
Contributor

loneil commented Feb 16, 2024

From discussion today with @esune
Plan to handle generating the correct payload for the deep link and accommodate for both link and QR. Normally this payload generation is not done until the short QR link is redirected to.

  1. Access the page first load

  2. It generates a connectionless or oob (config flag) payload that looks like this (depending on type)
    image

  3. It stores that in the database

  4. It generates the short link and QR code

  5. It returns that to the screen in the Deep Link Button

  6. It also returns the QR code

On deep link click

  • just action that link

On QR scan

  1. Follow redirect short link
  2. In handler, LOAD that from the DB instead of generating it
  3. Return same as before

On refresh timer

  1. Generate that again and overwrite the stored version
  2. return deep link and qr again to the page

@loneil loneil moved this from In Progress to In Review in CDT Enterprise Apps Feb 23, 2024
@esune esune moved this from In Review to Complete in CDT Enterprise Apps Mar 6, 2024
@esune esune closed this as completed Mar 6, 2024
@github-project-automation github-project-automation bot moved this from Complete to In Review in CDT Enterprise Apps Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants