Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): consolidate extension test workflows into matrix #1166

Merged
merged 8 commits into from
Jan 5, 2025
Merged

refactor(ci): consolidate extension test workflows into matrix #1166

merged 8 commits into from
Jan 5, 2025

Conversation

0x471
Copy link
Contributor

@0x471 0x471 commented Jan 3, 2025

Fixes #1144

@jonathanpwang
Copy link
Contributor

Delete the other extension-*.yml files once we can confirm the new one works

jonathanpwang
jonathanpwang reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! There are some extensions missing, and we should temporarily change the trigger rule to test the workflow on the branch. The workflow files this replaces can also be deleted.

@0x471 0x471 requested a review from jonathanpwang January 4, 2025 14:40
jonathanpwang
jonathanpwang reviewed Jan 4, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding rv32im to the matrix

@0x471 0x471 requested a review from jonathanpwang January 4, 2025 20:17
jonathanpwang
jonathanpwang approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang jonathanpwang merged commit bb2751c into openvm-org:main Jan 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor github workflows for extension unit tests
2 participants
@0x471 @jonathanpwang