Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor github workflows for extension unit tests #1144

Closed
jonathanpwang opened this issue Dec 30, 2024 · 1 comment · Fixed by #1166
Closed

Refactor github workflows for extension unit tests #1144

jonathanpwang opened this issue Dec 30, 2024 · 1 comment · Fixed by #1166
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jonathanpwang
Copy link
Contributor

jonathanpwang commented Dec 30, 2024

The workflows for extension tests are all the same:

  • *-extension.yml

They all just do some setup and then run cargo nextest on the circuit and test dirs.
To save files and ease maintenance, we can probably make some kind of matrix that just runs a separate workflow for each extension folder.

Note it is still important that each extension test is run on a separate runner so the tests are run in parallel.

The riscv.yml should not be included in the above extension tests, because those are the official riscv test vectors.

@0x471
Copy link
Contributor

0x471 commented Jan 3, 2025

Would be great if you can review the PR in your free time @jonathanpwang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants