Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: native compiler cleanup #1161

Merged
merged 4 commits into from
Jan 12, 2025
Merged

feat: native compiler cleanup #1161

merged 4 commits into from
Jan 12, 2025

Conversation

yi-sun
Copy link
Collaborator

@yi-sun yi-sun commented Jan 3, 2025

No description provided.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@yi-sun yi-sun force-pushed the native-cleanup branch 2 times, most recently from a9d4756 to 71939d1 Compare January 7, 2025 05:34

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

* feat: remove LOADW2 and STOREW2

* chore: remove LOADW2 and STOREW2 from docs

* chore: rename eDSL to native

* fix: benchmaks do not trigger on extensions

This comment has been minimized.

* chore: clean up comments in native compiler

* feat: add iterator for loop

* feat: convert more for loops

* fix: lint

* wip: zipped iterator

* fix: lint

* feat: iterator for loop in poseidon

* feat: optimize store

* fix: keep loop variable

* fix: store

* opt: try removing get_ref

* opt: remove duplicate get

* opt: remove idx

* chore: remove unused code

* fix: lint

* feat: add ZipFor and zipped_iter

* fix: lint

* feat: implement zipped_iter

* fix: faulty assert

* fix: read

* fix: lint

* fix: lint

* fix: vec

* feat: add more zipped_iter

* feat: optimize verify_batch

* fix: use first array for zipped_iter

* feat: add zipped_iter to hint

* chore: remove print

* feat: optimize hint_words

* fix: lifetime issues

* chore: add comment with example

* feat: use square-and-multiply for exp_reverse_bits_len

* fix: input size for exp_reverse_bits_len

* fix: slice and shift for V::size_of() greater than 1, optimization

* fix: replace incorrectly removed side effect

* feat: optimize adds

* feat: optimize for loops in duplex challenger

* chore: use larger runner for build workflow

* feat: address comments

* feat: remove all but the first end ptr in ZipFor

* feat: implement and use compile_zip! macro

* feat: add tests for iter and zip
* feat: add vectorization to native load store circuit

* chore: update comment

* feat: replace LOAD/STORE immediates with ADD

* fix: lint

* feat: add LOADW4 STOREW4 SHINTW4

* chore: rename SHINTW -> HINT_STOREW

* feat: optimize out 2 columns after removing immediates

* chore: remove TODO

* chore: extract opcode arrays into constants

* chore: remove magic number 4

* fix: update integration tests

* fix: test_vm_override_executor_height
* chore: remove unused Loop opcode

* chore: remove unused exp_bits<V> function

* chore: remove unused HintBitsU

* chore: remove unused functions

* chore: remove unused

* feat: remove assert_ne from Var

* fix: lint

* feat: remove LessThanV, LessThanVI

* chore: add comments

* fix: spelling of committed

* chore: remove unused get_ref

* chore: remove unused get_ref

* chore: remove unused ptr_at

* fix: cache address

* feat: remove Ref

* feat: remove assert_len

* fix: lint
@yi-sun yi-sun changed the title wip: native compiler cleanup feat: native compiler cleanup Jan 12, 2025
@yi-sun yi-sun marked this pull request as ready for review January 12, 2025 06:18
@yi-sun yi-sun merged commit 55d7015 into main Jan 12, 2025
22 checks passed
@yi-sun yi-sun deleted the native-cleanup branch January 12, 2025 06:27
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+19 [+0.5%]) 3,504 711,284 25,510,945 - - -
fibonacci_program (-16 [-0.3%]) 6,051 1,500,137 51,505,102 - - -
regex_program (+68 [+0.4%]) 19,064 4,190,904 165,028,173 - - -
fib_e2e 42,672 12,000,137 410,820,430 90,311 18,474,185 661,000,180
ecrecover_program (+34 [+1.3%]) 2,628 285,401 15,092,297 - - -

Commit: 431d5ea

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant