-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: native compiler cleanup #1161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yi-sun
force-pushed
the
native-cleanup
branch
2 times, most recently
from
January 7, 2025 05:34
a9d4756
to
71939d1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* feat: remove LOADW2 and STOREW2 * chore: remove LOADW2 and STOREW2 from docs * chore: rename eDSL to native * fix: benchmaks do not trigger on extensions
yi-sun
force-pushed
the
native-cleanup
branch
from
January 10, 2025 07:23
1d7e7e2
to
a7ec44f
Compare
This comment has been minimized.
This comment has been minimized.
* chore: clean up comments in native compiler * feat: add iterator for loop * feat: convert more for loops * fix: lint * wip: zipped iterator * fix: lint * feat: iterator for loop in poseidon * feat: optimize store * fix: keep loop variable * fix: store * opt: try removing get_ref * opt: remove duplicate get * opt: remove idx * chore: remove unused code * fix: lint * feat: add ZipFor and zipped_iter * fix: lint * feat: implement zipped_iter * fix: faulty assert * fix: read * fix: lint * fix: lint * fix: vec * feat: add more zipped_iter * feat: optimize verify_batch * fix: use first array for zipped_iter * feat: add zipped_iter to hint * chore: remove print * feat: optimize hint_words * fix: lifetime issues * chore: add comment with example * feat: use square-and-multiply for exp_reverse_bits_len * fix: input size for exp_reverse_bits_len * fix: slice and shift for V::size_of() greater than 1, optimization * fix: replace incorrectly removed side effect * feat: optimize adds * feat: optimize for loops in duplex challenger * chore: use larger runner for build workflow * feat: address comments * feat: remove all but the first end ptr in ZipFor * feat: implement and use compile_zip! macro * feat: add tests for iter and zip
* feat: add vectorization to native load store circuit * chore: update comment * feat: replace LOAD/STORE immediates with ADD * fix: lint * feat: add LOADW4 STOREW4 SHINTW4 * chore: rename SHINTW -> HINT_STOREW * feat: optimize out 2 columns after removing immediates * chore: remove TODO * chore: extract opcode arrays into constants * chore: remove magic number 4 * fix: update integration tests * fix: test_vm_override_executor_height
* chore: remove unused Loop opcode * chore: remove unused exp_bits<V> function * chore: remove unused HintBitsU * chore: remove unused functions * chore: remove unused * feat: remove assert_ne from Var * fix: lint * feat: remove LessThanV, LessThanVI * chore: add comments * fix: spelling of committed * chore: remove unused get_ref * chore: remove unused get_ref * chore: remove unused ptr_at * fix: cache address * feat: remove Ref * feat: remove assert_len * fix: lint
Commit: 431d5ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.