feat: remove unused parts of native compiler #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zlangley
approved these changes
Jan 12, 2025
| Array::Dyn(ptr, len) => { | ||
| if self.flags.debug { | ||
| let valid = self.lt(index, len.clone()); | ||
| self.assert_var_eq(valid, C::N::ONE); |
There was a problem hiding this comment.
If we want to keep debug, a useful check here that is not lt is that index != len (since most index-out-of-bounds happen at len). I had used this to find some bugs at some point.
There was a problem hiding this comment.
Hmm, unfortunately I also removed assert_ne in this PR since it was only used once in the entire codebase (to check non-zero). I'll come back to revisit this.
yi-sun
force-pushed
the
feat/native-load-store-block
branch
from
7e00bd1 to
1cae05e
Compare
Base automatically changed from
feat/native-load-store-block
to
native-cleanup
January 12, 2025 06:06
yi-sun
force-pushed
the
feat/native-remove-unused
branch
from
975f6a2 to
1618343
Compare
Commit: 1618343 |
yi-sun
added a commit
that referenced
this pull request
Jan 12, 2025
* chore: remove unused Loop opcode * chore: remove unused exp_bits<V> function * chore: remove unused HintBitsU * chore: remove unused functions * chore: remove unused * feat: remove assert_ne from Var * fix: lint * feat: remove LessThanV, LessThanVI * chore: add comments * fix: spelling of committed * chore: remove unused get_ref * chore: remove unused get_ref * chore: remove unused ptr_at * fix: cache address * feat: remove Ref * feat: remove assert_len * fix: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes:
DslIr::Loopexp_bits<V>and other assortedexp_bitsfunctionsHintBitsUassert_neLessThanV,LessThanVIget_ptr, get_ref, ptr_atRefArray<C, V>.assert_len()Closes INT-2994, INT-3014