Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aggregate and summarize metrics with rust #1154

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Conversation

jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Jan 2, 2025

closes INT-2940

Now individual benchmark-call.yml is only responsible for uploading metric json to s3 (we could use github artifact, but we're already using s3).
In benchmark.yml, we use openvm-prof to generate markdown for each benchmark from metric json and then create a summary markdown all at once.

Now that markdown creation is all in benchmark.yml, I made benchmark.yml allow workflow dispatch for ease of use (but untested).

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Jan 2, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 1,626 (+634 [+0.3%]) 195,373 (+109342 [+1.4%]) 8,122,104 - - -
fibonacci_program (-57 [-0.8%]) 7,337 1,500,137 51,505,102 - - -
regex_program 22,262 4,190,904 165,028,173 - - -
ecrecover_program (-33 [-1.1%]) 2,915 290,016 15,230,037 - - -

Commit: 6e135a0

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit 1425c1d into main Jan 2, 2025
10 checks passed
@jonathanpwang jonathanpwang deleted the prof/summary branch January 2, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant