Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diffs to detailed metrics #1155

Open
jonathanpwang opened this issue Jan 2, 2025 · 2 comments · May be fixed by #1165
Open

Add diffs to detailed metrics #1155

jonathanpwang opened this issue Jan 2, 2025 · 2 comments · May be fixed by #1165

Comments

@jonathanpwang
Copy link
Contributor

In #1154 openvm-prof has rudimentary diff support for aggregate and summary metrics. We should add it back for detailed metrics.
@jonathanpwang
Copy link
Contributor Author

@keroro520 this is the updated issue for what we'd discussed

@keroro520
Copy link
Contributor

@keroro520 this is the updated issue for what we'd discussed

Thanks @jonathanpwang
I am refactoring the previous code, and will submit the refactored code and add 'diff' function asap.

@keroro520 keroro520 linked a pull request Jan 3, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(metric_unify): refactor and add diff command keroro520/openvm
2 participants
@keroro520 @jonathanpwang