-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCE] Upgrade ONNX to v1.13.0 for security issue #1688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
goodsong81
commented
Feb 14, 2023
•
edited
Loading
edited
- Upgrade onnx==1.10.1 -> 1.13.0
- Fix protobuf conflict (due to onnx upgrade)
- Fix tensorboard conflict (due to protobuf)
- Fix mmdeploy conflict (due to protobuf conflict)
- Temporary fork: https://github.com/goodsong81/mmdeploy/tree/v0.12.1
- Loosen protobuf criteri
- Include @eugene123tw's fix: Fix bug in remove_imports open-mmlab/mmdeploy#1743
- To use otxdeploy==0.12.1 until mmdeploy packages are available on PyPI
- Changed mmcv-full install in tox (local build -> wheel)
- (Minor) Enhance tox build speed using dependencies
Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Songki Choi <[email protected]>
github-actions
bot
added
BUILD
DEPENDENCY
Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
labels
Feb 14, 2023
JihwanEom
previously approved these changes
Feb 14, 2023
sungmanc
previously approved these changes
Feb 14, 2023
Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Songki Choi <[email protected]>
Codecov ReportBase: 63.38% // Head: 63.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1688 +/- ##
===========================================
+ Coverage 63.38% 63.39% +0.01%
===========================================
Files 508 508
Lines 31368 31369 +1
===========================================
+ Hits 19882 19887 +5
+ Misses 11486 11482 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eunwoosh
previously approved these changes
Feb 14, 2023
sungmanc
approved these changes
Feb 14, 2023
eunwoosh
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BUILD
DEPENDENCY
Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.