Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in remove_imports #1743

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

eugene123tw
Copy link

IndexError: list index out of range error as model.opset_import list is changing dynamically

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

IndexError: list index out of range error as `model.opset_import list` is changing dynamically
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2023

CLA assistant check
All committers have signed the CLA.

@lvhan028
Copy link
Collaborator

@eugene123tw thanks for your contribution.
Could you open another PR for dev-1.x branch?

@lvhan028 lvhan028 merged commit e519898 into open-mmlab:master Feb 13, 2023
goodsong81 pushed a commit to goodsong81/mmdeploy that referenced this pull request Feb 13, 2023
* Fix bug in remove_imports

IndexError: list index out of range error as `model.opset_import list` is changing dynamically

* pre-commit fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants