Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add new docs with Sphinx (.md) #885

Closed
wants to merge 23 commits into from

Conversation

chuneuny-emily
Copy link
Contributor

@chuneuny-emily chuneuny-emily commented Mar 23, 2023

Summary

This PR contain the restructured documentation with Sphinx.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (f67fc90) 78.49% compared to head (dddc750) 78.49%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #885      +/-   ##
===========================================
- Coverage    78.49%   78.49%   -0.01%     
===========================================
  Files          206      206              
  Lines        24939    24939              
  Branches      5007     5007              
===========================================
- Hits         19577    19575       -2     
- Misses        4236     4237       +1     
- Partials      1126     1127       +1     
Flag Coverage Δ
macos-11_Python-3.8 ?
ubuntu-20.04_Python-3.8 78.49% <ø> (ø)
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chuneuny-emily chuneuny-emily added DOC Improvements or additions to documentation CI Any changes in CI setting labels Mar 23, 2023
@chuneuny-emily chuneuny-emily added this to the 1.2.0 milestone Mar 23, 2023
docs/emily.log Outdated Show resolved Hide resolved
datum export --format tf_detection_api -- --save-images

- Annotate MS COCO dataset, extract image subset, re-annotate it in
`CVAT <https://github.com/openvinotoolkit/cvat>`_, update old dataset:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may be possible to remove re-annotate part in CVAT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you want to delete the re-annotate part? It explains how to update the new annotation in Datumaro, and I think it's good to have one. e.g., datum project update reannotation-upd

@yunchu yunchu mentioned this pull request Mar 23, 2023
6 tasks
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to merge the doc-related PRs to docs-rework branch first, don't we?

docs/emily.log Outdated Show resolved Hide resolved
.github/workflows/github_pages.yml Outdated Show resolved Hide resolved
docs/source/docs/user-manual/command-reference/checkout.md Outdated Show resolved Hide resolved
@chuneuny-emily
Copy link
Contributor Author

We agreed to merge the doc-related PRs to docs-rework branch first, don't we?

Yes, but the work in the form of the previous copy was already in progress there, so I got confused and took a branch again from the latest develop. You can also delete the existing docs-rework branch and rename it to that one.

@chuneuny-emily chuneuny-emily changed the title Add new docs with Sphinx Add new docs with Sphinx (.md) Mar 23, 2023
@chuneuny-emily chuneuny-emily changed the base branch from develop to docs-rework March 24, 2023 02:07
@chuneuny-emily chuneuny-emily changed the base branch from docs-rework to develop March 24, 2023 02:10
@chuneuny-emily chuneuny-emily changed the title Add new docs with Sphinx (.md) [WIP] Add new docs with Sphinx (.md) Mar 24, 2023
@chuneuny-emily chuneuny-emily marked this pull request as draft March 24, 2023 02:12
chuneuny-emily and others added 11 commits March 24, 2023 14:29
To exclude 'tab-in-indent' error from whitespace checking on Makefile
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary


![image](https://user-images.githubusercontent.com/89109581/229419480-c4835066-9253-4a48-8a98-6630e951c34b.png)

<!--
Resolves #111 and #222.
Depends on #1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem #1234
-->

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [ ] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [ ] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [ ] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary

<!--
Resolves #111 and #222.
Depends on #1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem #1234
-->

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [ ] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [ ] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [ ] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
@yunchu yunchu closed this Apr 10, 2023
@yunchu
Copy link
Contributor

yunchu commented Apr 10, 2023

Changes reviewed on the PR was applied #917 and merged.

@vinnamkim vinnamkim deleted the sphinx-docs-rework branch April 17, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Any changes in CI setting DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants