Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hierarchical ImageNet-like dataset format #1528

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

itrushkin
Copy link
Contributor

Summary

CVS-143460

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@itrushkin itrushkin requested review from a team as code owners June 12, 2024 05:54
@itrushkin itrushkin requested review from vinnamkim and removed request for a team June 12, 2024 05:54
@itrushkin itrushkin changed the title Add detection and import of hierarchical ImageNet-like dataset Add hierarchical ImageNet-like dataset format Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (44cc56a) to head (f24ea6e).
Report is 90 commits behind head on develop.

Files Patch % Lines
src/datumaro/plugins/data_formats/imagenet.py 78.72% 3 Missing and 7 partials ⚠️
src/datumaro/plugins/data_formats/image_dir.py 83.33% 1 Missing and 2 partials ⚠️
src/datumaro/plugins/data_formats/yolo/exporter.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1528      +/-   ##
===========================================
+ Coverage    80.85%   81.04%   +0.18%     
===========================================
  Files          271      276       +5     
  Lines        30689    32395    +1706     
  Branches      6197     6586     +389     
===========================================
+ Hits         24815    26255    +1440     
- Misses        4489     4688     +199     
- Partials      1385     1452      +67     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.03% <80.00%> (+0.19%) ⬆️
windows-2022_Python-3.10 81.02% <80.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make Windows CI green

src/datumaro/components/importer.py Outdated Show resolved Hide resolved
src/datumaro/plugins/data_formats/imagenet.py Outdated Show resolved Hide resolved
Signed-off-by: Ilya Trushkin <[email protected]>
@itrushkin itrushkin requested a review from vinnamkim June 19, 2024 07:07
@wonjuleee wonjuleee merged commit c296000 into openvinotoolkit:develop Jun 21, 2024
7 of 8 checks passed
sooahleex added a commit to sooahleex/datumaro that referenced this pull request Jun 24, 2024
itrushkin added a commit to itrushkin/datumaro that referenced this pull request Jul 10, 2024
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary
CVS-143460
<!--
Resolves openvinotoolkit#111 and openvinotoolkit#222.
Depends on openvinotoolkit#1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem openvinotoolkit#1234
-->

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [x] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [ ] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [x] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```

---------

Signed-off-by: Ilya Trushkin <[email protected]>
chuneuny-emily pushed a commit that referenced this pull request Jul 10, 2024
Duplicate of #1528 but with `releases/1.8.0` base.

---------

Signed-off-by: Ilya Trushkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants