Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Fix some npcs bugs and change behaviour #613

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Conversation

dudantas
Copy link
Member

@dudantas dudantas commented May 28, 2022

This works with: opentibiabr/canary#396

Fixed:

  • Total cost for custom currencys
  • Bank npcs depot, transfer and withdraw logic

Changed:

  • MsgContains behaviour, added new function "MsgFind" so that we avoid some bugs in messages that have the same words
  • Added debug log for assistant with debug build

data/npclib/npc.lua Outdated Show resolved Hide resolved
data/npclib/npc.lua Outdated Show resolved Hide resolved
@dudantas dudantas changed the title Fix some npcs bugs Fix some npcs bugs and change behaviour May 28, 2022
Copy link
Contributor

@guispiller guispiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in order to some functions work in bank system, they need to have be changed.
How it should work:
Deposit:
unknown
Transfer:
unknown

@guispiller guispiller linked an issue Jun 11, 2022 that may be closed by this pull request
5 tasks
@majestyotbr majestyotbr marked this pull request as draft June 15, 2022 21:12
@dudantas dudantas marked this pull request as ready for review June 30, 2022 03:59
@dudantas dudantas dismissed guispiller’s stale review June 30, 2022 04:00

Logic fixed by the last commit

@dudantas dudantas merged commit 1a9813d into main Jun 30, 2022
@dudantas dudantas deleted the fix-some-npcs-behavior branch June 30, 2022 04:59
JoaoCRDias pushed a commit to JoaoCRDias/otservbr-global that referenced this pull request Jul 27, 2022
This works with canary commit: opentibiabr/canary@5b25b43

Fixed:
Total cost for custom currencys
Bank npcs depot, transfer and withdraw logic

Changed:
MsgContains behaviour, added new function "MsgFind" so that we avoid some bugs in messages that have the same words
Added debug log for assistant with debug build

Co-authored-by: Spiller <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npcConfig.currency trade performing unintended actions
3 participants