This repository has been archived by the owner on May 20, 2023. It is now read-only.
Fix banshee quest and wand of darkness attributes #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed ID's for the 1st, 2nd and 6th seal. Added another key word to The Queen of the Banshee's NPC.
Small correction to items.xml to add crit damage and crit percent to wand of darkness.
Behaviour
Actual
Currently, the first action will execute the revert function with a stone wall. The second seal (pearls) needs item ID's that aren't valid to access the teleporter. The sixth seal (fire camps) requires walls, instead of active fires to open the teleporter. The NPC has a keyword 'SEVENTH' that doesn't currently work.
The item 'Wand of Darkness' does not give critical chance or damage when equipped.
Expected
The first action to remove the magic walls and gain entry to the quest area should be replaced with magic walls, not stone walls. The seals should require the correct item ID's to work. The NPC should respond to the keyword 'Seventh'. Wand of Darkness should give crit chance and damage.
Fixes
*Changed ID's on the related scripts
*Added secondary keyword to The Queen of the Banshees
*Added crit chance and damage lines to wand of darkness in items.xml
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist