Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Fix banshee quest and wand of darkness attributes #645

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

Sparkz023
Copy link
Contributor

Description

Fixed ID's for the 1st, 2nd and 6th seal. Added another key word to The Queen of the Banshee's NPC.

Small correction to items.xml to add crit damage and crit percent to wand of darkness.

Behaviour

Actual

Currently, the first action will execute the revert function with a stone wall. The second seal (pearls) needs item ID's that aren't valid to access the teleporter. The sixth seal (fire camps) requires walls, instead of active fires to open the teleporter. The NPC has a keyword 'SEVENTH' that doesn't currently work.

The item 'Wand of Darkness' does not give critical chance or damage when equipped.

Expected

The first action to remove the magic walls and gain entry to the quest area should be replaced with magic walls, not stone walls. The seals should require the correct item ID's to work. The NPC should respond to the keyword 'Seventh'. Wand of Darkness should give crit chance and damage.

Fixes

*Changed ID's on the related scripts
*Added secondary keyword to The Queen of the Banshees
*Added crit chance and damage lines to wand of darkness in items.xml

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A - Replaced item ID's and completed the quest in full again on a local test server. Spoke to the NPC using both keywords (Seventh and Seventh Seal). Equipped and tested crit chance/damage on training machines.
  • Test B

Test Configuration:

  • Server Version: 1.3.1
  • Client: 12.86
  • Operating System: Ubuntu 20.2

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Fixed ID's for the 1st, 2nd and 6th seal. Added another key word to The Queen of the Banshee's NPC.

Small correction to items.xml
@majestyotbr majestyotbr changed the title Banshee Quest fixes + Wand of Darkness fix Fix banshee quest and wand of darkness attributes Jun 13, 2022
Copy link
Contributor

@guispiller guispiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@majestyotbr majestyotbr merged commit b76aa67 into opentibiabr:main Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants