fix: safer iteration over reward containers #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beats-dh
approved these changes
Jul 23, 2023
omeranha
approved these changes
Jul 24, 2023
dudantas
approved these changes
Jul 28, 2023
Container:createLootItem now returns false when no loot was created (either by error or because we rolled a random that didn't add it). This was causing a warning to pop up on the monster callback. This was a harmless warning, but we were missing logs when something actually went wrong (not enough space on the corpse or invalid itemID). This adds logs inside createLootItem and silences the spurious alerts above.
dudantas
approved these changes
Jul 28, 2023
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
majestyotbr
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fixed some iterations related to reward collect.
• Fixed for the loot on the body of bosses to use quickloot and not reward collect.
• Fixed not being able to open the corpse any more after the reward bag is empty.