fix: use loot modifiers correctly when creating loot #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luan
force-pushed
the
luan/silence-warnings
branch
from
6dfa224 to
067a086
Compare
luan
changed the title
luan
force-pushed
the
luan/silence-warnings
branch
from
0e36e4e to
89562f6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dudantas
approved these changes
Jul 28, 2023
luan
added a commit
that referenced
this pull request
Jul 28, 2023
Container:createLootItem now returns false when no loot was created (either by error or because we rolled a random that didn't add it). This was causing a warning to pop up on the monster callback. This was a harmless warning, but we were missing logs when something actually went wrong (not enough space on the corpse or invalid itemID). This adds logs inside createLootItem and silences the spurious alerts above.
majestyotbr
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container:createLootItemnow returns false when no loot was created (either by error or because we rolled a random that didn't add it). This was causing a warning to pop up on the monster callback. This was a harmless warning but we were missing logs when something actually went wrong (not enough space on the corpse or invalid itemID).This adds logs inside
createLootItemand silences the spurious alerts above.