Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codelab] Add clarification on netdata show changes #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[codelab] Add clarification on netdata show changes #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cf7df4
clarify change in on-link prefix shown in netdata
Alami-Amine Oct 10, 2023
9769917
integrating comments
Alami-Amine Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/en/codelabs/openthread-border-router/index.lab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ Done
> The example output of the `netdata show` command gives
>
> * an OMR prefix `fd76:a5d1:fcb0:1707::/64` for creating an OMR address that can be reached from the Wi-Fi/Ethernet network (you may notice that there is an IPv6 address `fd76:a5d1:fcb0:1707:f3c7:d88c:efd1:24a9` that starts with the OMR prefix);
> * an external route for the on-link prefix `fd49:7770:7fc5:0::/64` which is created by OTBR when no IPv6 network is already present on the Wi-Fi/Ethernet link.
> * an external route for the on-link prefix `fd49:7770:7fc5:0::/64` which is created by OTBR when no IPv6 network is already present on the Wi-Fi/Ethernet link. More recent commits will always publish `fc00::/7` in netdata instead of the specific on-link prefix; `fd49:7770:7fc5:0::/64` in this case.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about simplifying to something like:

Suggested change
> * an external route for the on-link prefix `fd49:7770:7fc5:0::/64` which is created by OTBR when no IPv6 network is already present on the Wi-Fi/Ethernet link. More recent commits will always publish `fc00::/7` in netdata instead of the specific on-link prefix; `fd49:7770:7fc5:0::/64` in this case.
> * an external route - `fc00::/7` if the border router does not have an upstream default route or `::/0` if the border router has an upstream default route.

This is the expected behavior for all Thread BRs going forward.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure that sounds good assuming people only use latest commits , i would also have to change the output of the "net data show". I guess its better to put fc00::/7 than just ::/0 there.

> * a SRP server Service with service number `5d` and SRP server UDP port which will be used by a Thread SRP end device.
> * a BBR Service with service number `0x01`;

Expand Down