[codelab] Add clarification on netdata show changes #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vyrastas
reviewed
Oct 10, 2023
Vyrastas
approved these changes
Oct 10, 2023
jwhui
reviewed
Oct 11, 2023
| @@ -212,7 +212,7 @@ Done | |||
| > The example output of the `netdata show` command gives | |||
| > | |||
| > * an OMR prefix `fd76:a5d1:fcb0:1707::/64` for creating an OMR address that can be reached from the Wi-Fi/Ethernet network (you may notice that there is an IPv6 address `fd76:a5d1:fcb0:1707:f3c7:d88c:efd1:24a9` that starts with the OMR prefix); | |||
| > * an external route for the on-link prefix `fd49:7770:7fc5:0::/64` which is created by OTBR when no IPv6 network is already present on the Wi-Fi/Ethernet link. | |||
| > * an external route for the on-link prefix `fd49:7770:7fc5:0::/64` which is created by OTBR when no IPv6 network is already present on the Wi-Fi/Ethernet link. More recent commits will always publish `fc00::/7` in netdata instead of the specific on-link prefix; `fd49:7770:7fc5:0::/64` in this case. | |||
There was a problem hiding this comment.
What about simplifying to something like:
Suggested change
| > * an external route for the on-link prefix `fd49:7770:7fc5:0::/64` which is created by OTBR when no IPv6 network is already present on the Wi-Fi/Ethernet link. More recent commits will always publish `fc00::/7` in netdata instead of the specific on-link prefix; `fd49:7770:7fc5:0::/64` in this case. | |
| > * an external route - `fc00::/7` if the border router does not have an upstream default route or `::/0` if the border router has an upstream default route. |
This is the expected behavior for all Thread BRs going forward.
There was a problem hiding this comment.
sure that sounds good assuming people only use latest commits , i would also have to change the output of the "net data show". I guess its better to put fc00::/7 than just ::/0 there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit clarifies that the command "netdata show" will not show/publish the full on-link prefix anymore (This change was done in openthread/openthread#8986.) and that instead we will only see fc00::/7 instead.