Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes docker run command to allow host receiving RA packets. #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions site/en/guides/border-router/docker/run.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,27 @@ sure to run `sudo modprobe ip6table_filter` for OTBR firewall support.
This allows OTBR scripts to create rules inside the Docker container
before `otbr-agent` starts.

In a new terminal window, start OTBR Docker, referencing the RCP's serial port.
For example, if the RCP is mounted at `/dev/ttyACM0`:
Run the following commands before starting the container. That enables
the IPv6 in the host machine and the IP forwarding.
Comment on lines +35 to +36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can say

Enable IPv6 and IP forwarding on the host machine, before starting the container:


```
$ docker run --sysctl "net.ipv6.conf.all.disable_ipv6=0 net.ipv4.conf.all.forwarding=1 net.ipv6.conf.all.forwarding=1" -p 8080:80 --dns=127.0.0.1 -it --volume /dev/ttyACM0:/dev/ttyACM0 --privileged openthread/otbr --radio-url spinel+hdlc+uart:///dev/ttyACM0
sudo sysctl -w net.ipv6.conf.all.disable_ipv6=0
sudo sysctl -w net.ipv4.conf.all.forwarding=1
sudo sysctl -w net.ipv6.conf.all.forwarding=1
```

Upon success, you should have output similar to this:
In a new terminal window, start OTBR Docker container, referencing the RCP's serial port, as in the next command.

> Notes: Consult the specific documentation from the used RCP and analyze if further
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:

not Notes

configuration is necessary, for example, setting up baudrate:
`--radio-url 'spinel+hdlc+uart:///dev/ttyUSB0?uart-baudrate=1000000'`, also replace `enp3s0` by the name of your interface on the computer running otbr docker, ex: `wlan0`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also replace enp3s0 by the name of your interface on the computer running otbr docker, ex: wlan0

I think it may be more clear to move this line before the command example. In most cases I think a user need to customize the backbone interface argument.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep it in order, so if they need to address the item in the note first, that should be first, then do

"In a new terminal window, start the OTBR Docker container, referencing the RCP's serial port:"

Then the docker run command


```
$ docker run --net=host --dns=127.0.0.1 -it --volume /dev/ttyACM0:/dev/ttyACM0 --privileged openthread/otbr --radio-url spinel+hdlc+uart:///dev/ttyACM0 -B enp3s0
```


Upon success, you should have the initial output similar to this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch this back to what it was, please.

Upon success, you should have output similar to this:


```
WARNING: Localhost DNS setting (--dns=127.0.0.1) may fail in containers.
Expand Down
2 changes: 1 addition & 1 deletion site/en/guides/border-router/docker/test-connectivity.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Select **FORM** to form the Thread network. Check the output in the terminal win
otbr-agent[224]: [INFO]-CLI-----: execute command: prefix add fd11:22::/64 pasor
```

This output is required for internet connectivty for the Thread network.
This output is required for internet connectivity for the Thread network.

## Step 2: Bring up a second Thread node

Expand Down