Fixes docker run command to allow host receiving RA packets. #113
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Note: Already signed the CLA. |
| ``` | ||
| > Notes: Consult the specific documentation from the used RCP and analyze if further | ||
| configuration is necessary, for example, setting up baudrate: | ||
| `--radio-url spinel+hdlc+uart:///dev/ttyUSB0?uart-baudrate=1000000`, also replace `enp3s0` by the name of your interface on the computer running otbr docker, ex: `wlan0`. |
There was a problem hiding this comment.
? is special for shell
| `--radio-url spinel+hdlc+uart:///dev/ttyUSB0?uart-baudrate=1000000`, also replace `enp3s0` by the name of your interface on the computer running otbr docker, ex: `wlan0`. | |
| `--radio-url 'spinel+hdlc+uart:///dev/ttyUSB0?uart-baudrate=1000000'`, also replace `enp3s0` by the name of your interface on the computer running otbr docker, ex: `wlan0`. |
There was a problem hiding this comment.
What should be the suggested change for other environments?
saramonteiro
force-pushed
the
docker_run_fix
branch
2 times, most recently
from
9d4eb9c to
c90e703
Compare
| ``` | ||
| > Notes: Consult the specific documentation from the used RCP and analyze if further | ||
| configuration is necessary, for example, setting up baudrate: | ||
| `--radio-url 'spinel+hdlc+uart:///dev/ttyUSB0?uart-baudrate=1000000'`, also replace `enp3s0` by the name of your interface on the computer running otbr docker, ex: `wlan0`. |
There was a problem hiding this comment.
also replace
enp3s0by the name of your interface on the computer running otbr docker, ex:wlan0
I think it may be more clear to move this line before the command example. In most cases I think a user need to customize the backbone interface argument.
There was a problem hiding this comment.
We should keep it in order, so if they need to address the item in the note first, that should be first, then do
"In a new terminal window, start the OTBR Docker container, referencing the RCP's serial port:"
Then the docker run command
saramonteiro
force-pushed
the
docker_run_fix
branch
from
c90e703 to
c90638c
Compare
| ``` | ||
|
|
||
|
|
||
| Upon success, you should have the initial output similar to this: |
There was a problem hiding this comment.
Can you switch this back to what it was, please.
Upon success, you should have output similar to this:
| Run the following commands before starting the container. That enables | ||
| the IPv6 in the host machine and the IP forwarding. |
There was a problem hiding this comment.
You can say
Enable IPv6 and IP forwarding on the host machine, before starting the container:
| ``` | ||
| > Notes: Consult the specific documentation from the used RCP and analyze if further | ||
| configuration is necessary, for example, setting up baudrate: | ||
| `--radio-url 'spinel+hdlc+uart:///dev/ttyUSB0?uart-baudrate=1000000'`, also replace `enp3s0` by the name of your interface on the computer running otbr docker, ex: `wlan0`. |
There was a problem hiding this comment.
We should keep it in order, so if they need to address the item in the note first, that should be first, then do
"In a new terminal window, start the OTBR Docker container, referencing the RCP's serial port:"
Then the docker run command
| Upon success, you should have output similar to this: | ||
| In a new terminal window, start OTBR Docker container, referencing the RCP's serial port, as in the next command. | ||
|
|
||
| > Notes: Consult the specific documentation from the used RCP and analyze if further |
|
@saramonteiro , any plans to move this PR forward? |
This bring small changes for the docker run command to allow the computer (and other devices in the network) to have access to the RA packets.
This a result from this issue: openthread/ot-br-posix#1789