Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split footway map key string #4447

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Collaborator

Changes this mapnik map key
image
to this
image
and the same for cyclemap.

I'm not entirely sure that it should be done, but here's a complaint #1087 claiming that it's difficult to translate the combined highway=footway / highway=path string correctly.

The rendering is combined though on both mapnik and cyclemap layers.

@tomhughes
Copy link
Member

Does highway=path always get rendered as a footpath though? or does it depend on what tags it is combined with?

As I understand it (and it's not a tag I ever use) it's a generic tag that covers all sorts of paths and access tags or something are then used to provide the detail.

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Jan 1, 2024

@AntonKhorev
Copy link
Collaborator Author

Does highway=path always get rendered as a footpath though?

in 95% of the cases:

[feature = 'highway_path'][bicycle != 'designated'][horse != 'designated']

https://taginfo.openstreetmap.org/tags/highway%3Dpath#combinations

4.38%
bicycle=designated

0.10%
horse=designated

@tomhughes
Copy link
Member

But at the end of the day the text in the key is not supposed to be interpreted literally as a tag value, just generically as "this is a foot path".

It's a bit odd that we use footway in the key really as footpath would be more typical english.

@AntonKhorev AntonKhorev marked this pull request as draft April 30, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants