Split changeset comment handling into its own controller #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preserves the API endpoints and HTTP methods, which could be changed in the next API version
…ntroller tests out
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors changeset comment handling into its own controller, and renames the controller methods accordingly. It doesn't change the API - that can wait for a future API version.
@Nikerabbit this PR contains translation key renaming:
changeset.rss.title_all->changeset_comments.index.title_allchangeset.rss.title_particular->changeset_comments.index.title_particularchangeset.rss.comment->changeset_comments.comment.commentand alsochangeset_comments.comments.commentchangeset.rss.commented_at_by_html->changeset_comments.comment.commented_at_by_htmlFor clarity,
changeset.rss.commented_at_htmlandchangeset.rss.fullare removed as they were unused.