Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

422 error when posting changeset comments #2057

Closed
willemarcel opened this issue Nov 13, 2018 · 4 comments
Closed

422 error when posting changeset comments #2057

willemarcel opened this issue Nov 13, 2018 · 4 comments

Comments

@willemarcel
Copy link
Contributor

Hi! I'm getting 422 error when trying to post comments to changesets with the endpoint: /api/0.6/changeset/#id/comment

I confirmed that the changesets are closed. The code that post comments had worked for months, but now it's failing. Could you check if there is some problem in the API or tell me if some API rule changed?

One of the changesets that I tried to post comments is: 64337024.

Thank you very much!

@gravitystorm
Copy link
Collaborator

gravitystorm commented Nov 13, 2018

I think this is a mistake I made in #2050 related to not having skip_before_action :verify_authenticity_token for the new changeset_comments controller. But I will need to investigate if this is the case, and if so, why the tests are passing.

Thanks for reporting it @willemarcel

@willemarcel
Copy link
Contributor Author

Thanks, @gravitystorm ! I think you linked the wrong PR, the correct seems to be this: #2050

@tomhughes
Copy link
Member

@gravitystorm I was trying to work out whether removing that was valid before I merged it but came to the conclusion that it was because those methods are not API are are only used via the web site.

@tomhughes
Copy link
Member

Ah no some of them are API so that is definitely needed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants