Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to opengraph meta tags #1073

Closed
wants to merge 2 commits into from
Closed

Add details to opengraph meta tags #1073

wants to merge 2 commits into from

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Oct 20, 2015

This PR fills in these opengraph tags:
og:image - set to full path of osm logo
og:title - set same as page title

closes #1066

@tomhughes
Copy link
Member

Ah oops. I've actually got a half finished and more complete version kicking around in my tree...

@bhousel
Copy link
Member Author

bhousel commented Oct 20, 2015

Hehe that's ok! Feel free to cancel this one if yours is more complete..

@mikelmaron
Copy link
Contributor

@tomhughes that's great. which tree and what's left to do?

@tomhughes tomhughes closed this in e62e879 Oct 26, 2015
@mikelmaron
Copy link
Contributor

@tomhughes curious to know, what's the release schedule of changes to openstreetmap-website?

@tomhughes
Copy link
Member

Release schedule? There isn't one things are normally pushed live more or less immediately.

@tomhughes
Copy link
Member

You can always tell what's live by looking at https://git.openstreetmap.org/rails.git/ and seeing where the live tag is.

@mikelmaron
Copy link
Contributor

Aha, I see, we missed something in this update

https://github.com/openstreetmap/openstreetmap-website/blob/master/app/views/layouts/_head.html.erb#L29

should be

<%= opengraph_tags(@title) %>

@tomhughes, can you update, or do you want a pull request?

@bhousel bhousel deleted the opengraph-tags branch March 2, 2016 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add details in description meta tag; and add og:description and twitter:description
3 participants