-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add details in description meta tag; and add og:description and twitter:description #1066
Comments
Why can't all these damned sites agree on one standard? How many of these tags are we going to be expected to add? How big does a site have to be before it becomes impossible for us to tell them to go take a long walk off a short pier when they come up with this nonsense... |
Yea, turns out they've kinda agreed. I think supporting the Open Graph standard should be enough. |
Does that mean we can kick out the tags "contact:facebook", "facebook", "contact:google_plus", "contact_twitter", "twitter", etc.? |
@woodpeck This is only about the HTML meta data for osm.org website, for sharing an URL. |
For reference, here is where the meta-tags are added. Not clear to me if both description and og:description metatags are necessary to cover everywhere we want better descriptions. Certainly for title, I think it just pulls from the title tag, doesn't require og:title. In either case, need to set up the value of this/these metatags to
|
The big problem I see is that we will have no idea what language to use for the description because what twitter/facebook/whatever fetches the page they won't be logged in, or presumably sending any Accept-Language header so we will just default to english. In any case in the first instance I was assuming we would just do a simple fixed description, not try and generate something custom for each different page. |
Yea, and there's no way to add alternate languages to og. So keep it simple, and set description to printable_name, and force to use the English text and the default "name" tag |
There is the https://developers.facebook.com/docs/opengraph/guides/internationalization#bestpractices discusses OG localization in the context of Facebook, and a
I can't find a reference to @mikelmaron Could you provide what you think the open graph properties would be for a few example objects? |
After looking into it more, the only addition needed now is Facebook uses So in summary, I think adding |
What about |
Agree that it would be great to do more with Also, "required" in practice isn't enforced. There are four required OG tags, but right now OSM just has the one. |
Can this be closed after e62e879 ? |
Well that depends - this ticket is sufficiently vague that it's hard to know what will count as it being completely fixed. In particular this specifically asked for My plan was to extend things to allow further page specific customisation and then, within reason, allow people to offer patches to make pages add more specific details. |
We whittled down the requirement in the comments. Thanks @tomhughes. Closing |
Adding more detail in the description meta-tag, and adding additional meta-tag, is an easy way to improve sharing of OSM links. For instance, a link to an OSM feature can include the name and type of feature in the description meta-tags.
Related to #739, which specs out possibilities and issues for addition of map image during sharing.
The text was updated successfully, but these errors were encountered: