-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revised road key and icons for data browser #1070
Conversation
Change road icons in the data browser to be the same colours as the revised road colours in the standard map style. The top and bottom lines for motorway, trunk and primary are in the casing colours, secondary and tertiary are 50% intensity of casing colour. Tertiary is made deeper.
The carto osm change is not live on the tile servers, as no release with this change had been tagged. |
Update colours for main roads to match gravitystorm/openstreetmap-carto#1736 and replace the OSM keywords trunk, primary and secondary (which have different meanings from OSM use in some places) with a new keyword main_road (main road),
Correct location of main_road, it lives under key
So this is a rather more drastic change than I was expecting... I assumed it was just updating the colours, but it actually merges all the trunk/primary/secondary roads into one which I'm not sure is a good idea and on top that it means that key entry will look very different to all the others because it will have three samples beside it not one. |
I've put a live site up at http://tomh.apis.dev.openstreetmap.org/ with this applied, if people could have a look and see what they think? |
Roads under construction at the bottom of the legend in http://tomh.apis.dev.openstreetmap.org/ use the old colours? @matkoniecz sorry - my original comment was ambiguous. I've updated it. |
Most likely it is result of rerender in progress - parts of map are displayed in the new style, parts in the old. Also, in cases of problems like that it is a good idea to specify location of problems. |
I am not sure is it intentional or not but road on map and road in legend are different - for example highway=secondary in legend has the same casing width as other roads but on map it is a bit smaller. And for example secondary casing is #707d05 or 9eae23 (depending on zoom level) - it never is #AFBB62
It makes legend less consistent. But it may be the first steep to make legend shorter, hopefully it will be anyway obvious what kind of road is more important. And it makes translation easier (for example trunk roads have no equivalent meaning in Polish)
Oh, right - it is about legend, where roads under construction are not changed to the new style. |
I have updated the image for construction and made the bottom roads the same width as the top two for main roads and under construction. |
The roads from tertiary downwards are missing in the legend, and they were missing in the old-colour legend already. |
It is awkward to put tertiary in the key now that the main difference is width. |
It's equally weird to leave the legend user guess what the slight grey road means. It might work to show the relative width difference. Some printed map have two symbols per legend line explained, maybe that might work for us as well, which also makes the legend shorter. |
Perhaps it is a good idea to merge this now for a start. The legend is needed perhaps now the most. |
Merged as f9570c4. |
These are a set of key entries and icons matching the new colours at gravitystorm/openstreetmap-carto#1736. The present entries for trunk, primary and secondary roads are replaced by one for main road (a new string that needs translating). The tertiary icon is wider to compensate for the pale colour.