Add lang attribute to translated text
#7998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess `html: false` is specified in the options (re: #7963) Update `text` functions to `html` to support inserting the `span` elements Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
quincylvania
added
the
localization
# Conflicts: # modules/ui/fields/combo.js
# Conflicts: # modules/ui/commit_warnings.js # modules/ui/field.js # modules/ui/fields/wikidata.js # modules/ui/fields/wikipedia.js # modules/ui/full_screen.js # modules/ui/panels/history.js # modules/ui/sections/entity_issues.js # modules/ui/sections/map_features.js # modules/ui/sections/raw_member_editor.js # modules/ui/sections/validation_rules.js # modules/ui/tag_reference.js
Add `t.html` function for getting the string with the `lang` attribute
Clean up a few things from prior commit
|
I ended up making this backwards-compatible, so developers won't see different behavior from the Haven't yet achieved 100% coverage of the UI, but I'm happy with the groundwork so I went ahead and merged. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7963.
Turns out that adding a
langattribute to every text snippet in iD is a sweeping proposition 😬This type of change isn't ideal, but I think it's necessary in making iD a first-class multilingual app. We can't really have mixed text throughout the UI without specifying what text is in what language. And some users of iD will always see mixed text unless we had a professional translation team that reaches 100% coverage in every language for every release (highly unlikely).