Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lang HTML attribute for multilingual text #7963

Closed
quincylvania opened this issue Sep 9, 2020 · 0 comments · Fixed by #7998
Closed

Support lang HTML attribute for multilingual text #7963

quincylvania opened this issue Sep 9, 2020 · 0 comments · Fixed by #7998
Assignees
@quincylvania
Labels
accessibility Relates to personal ability or assistive tools localization Adapting iD across languages, regions, and cultures
Milestone
2.19.0

Comments

@quincylvania
Copy link
Collaborator

quincylvania commented Sep 9, 2020 •
edited
Loading

The lang attribute is used on HTML elements to specify the language, script, and locale of the contained text. Encoding this info explicitly helps web users in a number of ways, including:

  • Pronunciation in text-to-speech (critical for users of screen readers especially)
  • Formatting, such as how to break words when wrapping text between lines
  • Auto-transliteration, where a browser or extension translates foreign text into the user's language

Since iD isn't 100% translated into all languages, many mappers experience a mix of English and non-English strings. Adding lang attributes will improve this experience.

Re: #7713
@quincylvania quincylvania added localization Adapting iD across languages, regions, and cultures usability An issue with ease-of-use or design accessibility Relates to personal ability or assistive tools and removed usability An issue with ease-of-use or design labels Sep 9, 2020
@quincylvania quincylvania self-assigned this Sep 16, 2020
@quincylvania quincylvania added this to the 2.19.0 milestone Sep 16, 2020
quincylvania added a commit that referenced this issue Sep 16, 2020
@quincylvania
Make t function return a span element with a lang attribute unl…
32f8274 
…ess `html: false` is specified in the options (re: #7963)

Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
@quincylvania quincylvania mentioned this issue Sep 16, 2020
Merged
quincylvania added a commit that referenced this issue Sep 22, 2020
@quincylvania
Fix styling issue in panels
b92f0a6 
Add lang attribute to more text (re: #7963)
quincylvania added a commit that referenced this issue Sep 22, 2020
@quincylvania
Add the lang attribute to issue messages (re: #7963)
aa9b44a
quincylvania added a commit that referenced this issue Sep 22, 2020
@quincylvania
Add lang attribute to issue fix labels (re: #7963)
7b5df1b
quincylvania added a commit that referenced this issue Sep 23, 2020
@quincylvania
Add lang attribute to more display labels (re: #7963)
4600ab5
quincylvania added a commit that referenced this issue Sep 23, 2020
@quincylvania
Add lang attribute to more labels (re: #7963)
9da4c4b
quincylvania added a commit that referenced this issue Sep 23, 2020
@quincylvania
Add lang attribute to more display labels (re: #7963)
c443b28
quincylvania added a commit that referenced this issue Sep 23, 2020
@quincylvania
Add en fallback in coreLocalizer instead of utilDetect.browserLocales
bbbf401 
Include all preferred and fallback langauges in coreLocalizer.localeCodes even if higher-priority ones have 100% string coverage
Fallback to the user's preferred languages instead of directly to English when querying OSM wikibase documentation and Wikidata (re: #7996)
Add `lang` attribute to tag documentation text loaded from OSM wikibase or Wikidata (re: #7963)
quincylvania added a commit that referenced this issue Sep 24, 2020
@quincylvania
Add lang attribute to more display text (re: #7963)
4d51713
quincylvania added a commit that referenced this issue Sep 28, 2020
@quincylvania
Fix issue where names with en dashes couldn't be added (close #7536)
3b79335 
Add `lang` attribute to brand name dropdown labels (re: #7963)
quincylvania added a commit that referenced this issue Sep 29, 2020
@quincylvania
Add lang attribute to text in turn restriction editor (re: #7963)
79b6a9d
@quincylvania quincylvania mentioned this issue Oct 27, 2020
Merged
@1ec5 1ec5 mentioned this issue Nov 18, 2021
Merged
2 tasks
@tyrasd tyrasd mentioned this issue Jul 21, 2022
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quincylvania quincylvania

Labels
accessibility Relates to personal ability or assistive tools localization Adapting iD across languages, regions, and cultures
Projects
None yet
Milestone
2.19.0
Development

Successfully merging a pull request may close this issue.

Add lang attribute to translated text openstreetmap/iD
1 participant
@quincylvania