-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize swift-ring finalizer name #231
Standardize swift-ring finalizer name #231
Conversation
The swift-ring finalizer is created by a curl API request and not using lib-common. This patch standardizes the finalizer name by adding the missing domain name.
/test swift-operator-build-deploy-kuttl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm could use helper.GetFinalizer()
to get the finalizer for the swiftring, but the current string aligns with the finalizer provided via the lib-common change we did openstack-k8s-operators/lib-common#519 . could do that in a follow up
@@ -255,7 +255,7 @@ func (r *SwiftRingReconciler) reconcileDelete(ctx context.Context, instance *swi | |||
if err == nil { | |||
// This finalizer is directly set when creating the ConfigMap using | |||
// curl within the Job | |||
if controllerutil.RemoveFinalizer(ringConfigMap, "swift-ring/finalizer") { | |||
if controllerutil.RemoveFinalizer(ringConfigMap, "openstack.org/swiftring") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you bump lib-common you could use helper.GetFinalizer()
@@ -122,7 +122,7 @@ function push() { | |||
'${VERSION}' | |||
"name":"'${CM_NAME}'", | |||
"namespace":"'${NAMESPACE}'", | |||
"finalizers": ["swift-ring/finalizer"], | |||
"finalizers": ["openstack.org/swiftring"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use helper.GetFinalizer()
when render this script template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, indeed! Will change this in a follow up. Thx!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cschwede, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
252083b
into
openstack-k8s-operators:main
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
The swift-ring finalizer is created by a curl API request and not using lib-common. This patch standardizes the finalizer name by adding the missing domain name.
Related: openstack-k8s-operators/lib-common#519