Align finalizer with Custom Resource Definition doc #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Custom Resource Definition docs [1], custom finalizer names are expected to be in format "consist of a domain name, a forward slash and the name of the finalizer" (e.g. foo.bar/name). This aligns the finalizer provided by the helper to follow this definition and uses openstack.org/<gkv.kind> (all lower case) as the finalizer. [1] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#finalizers:~:text=Identifiers%20of%20custom%20finalizers%20consist%20of%20a%20domain%20name%2C%20a%20forward%20slash%20and%20the%20name%20of%20the%20finalizer Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/mariadb-operator
that referenced
this pull request
Jun 18, 2024
Signed-off-by: Martin Schuppert <[email protected]> Depends-on: openstack-k8s-operators/lib-common#519
stuggi
added a commit
to stuggi/mariadb-operator
that referenced
this pull request
Jun 18, 2024
Depends-on: openstack-k8s-operators/lib-common#519 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/infra-operator
that referenced
this pull request
Jun 18, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Jun 18, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Jun 18, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Jun 18, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
Jun 18, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/barbican-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/cinder-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/designate-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/designate-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/glance-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/glance-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/ironic-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/manila-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/neutron-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/neutron-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/neutron-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/octavia-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/openstack-baremetal-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/ovn-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/telemetry-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/nova-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/heat-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/placement-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 19, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 20, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/telemetry-operator
that referenced
this pull request
Jun 20, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 20, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 20, 2024
Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/barbican-operator#125 Depends-On: openstack-k8s-operators/cinder-operator#402 Depends-On: openstack-k8s-operators/designate-operator#178 Depends-On: openstack-k8s-operators/glance-operator#559 Depends-On: openstack-k8s-operators/heat-operator#380 Depends-On: openstack-k8s-operators/horizon-operator#332 Depends-On: openstack-k8s-operators/infra-operator#231 Depends-On: openstack-k8s-operators/ironic-operator#440 Depends-On: openstack-k8s-operators/keystone-operator#428 Depends-On: openstack-k8s-operators/lib-common#519 Depends-On: openstack-k8s-operators/manila-operator#287 Depends-On: openstack-k8s-operators/mariadb-operator#231 Depends-On: openstack-k8s-operators/neutron-operator#366 Depends-On: openstack-k8s-operators/nova-operator#794 Depends-On: openstack-k8s-operators/octavia-operator#330 Depends-On: openstack-k8s-operators/openstack-baremetal-operator#180 Depends-On: openstack-k8s-operators/ovn-operator#309 Depends-On: openstack-k8s-operators/placement-operator#215 Depends-On: openstack-k8s-operators/swift-operator#231 Depends-On: openstack-k8s-operators/telemetry-operator#414 Signed-off-by: Martin Schuppert <[email protected]>
5 tasks
gibizer
pushed a commit
to gibizer/mariadb-operator
that referenced
this pull request
Nov 21, 2024
Depends-on: openstack-k8s-operators/lib-common#519 Signed-off-by: Martin Schuppert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Custom Resource Definition docs [1], custom finalizer names are expected to be in format "consist of a domain name, a forward slash and the name of the finalizer" (e.g. foo.bar/name).
This aligns the finalizer provided by the helper to follow this definition and uses openstack.org/<gkv.kind> (all lower case) as the finalizer.
[1] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#finalizers:~:text=Identifiers%20of%20custom%20finalizers%20consist%20of%20a%20domain%20name%2C%20a%20forward%20slash%20and%20the%20name%20of%20the%20finalizer