Revert "Remove the deployed attribute from deployment" #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5a55c47. Without the status.Deployed boolean flag on OpenStackDataPlaneDeployment there is no mechanism in place to prevert the full reconcile of a Deployment. While the immutable annotation prevents user edits to the spec, other changes could still trigger Deployment reconciles. In the case of testing minor updates, it was discovered that when the ansible runner image as specified by the RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT env var in the openstack-operator csv is changed, it will re-execute the ansible for all existing Deployments. This breaks the minor update workflow as things are done out of order, and breaks the expectation that it is the user who starts ansible executions as opposed to automatically. Jira: OSPRH-8923 Signed-off-by: James Slagle <[email protected]>
slagle
requested review from
rabi,
fao89 and
ciecierski
and removed request for
stuggi and
igallagh-redhat
fao89
approved these changes
Jul 24, 2024
ciecierski
approved these changes
Jul 24, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciecierski, fao89, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e569d04
into
openstack-k8s-operators:main
8 checks passed
|
/cherrypick 18.0.0-proposed |
|
@slagle: new pull request created: #971 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5a55c47.
Without the status.Deployed boolean flag on OpenStackDataPlaneDeployment
there is no mechanism in place to prevert the full reconcile of a
Deployment. While the immutable annotation prevents user edits to the
spec, other changes could still trigger Deployment reconciles.
In the case of testing minor updates, it was discovered that when the
ansible runner image as specified by the
RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT env var in the
openstack-operator csv is changed, it will re-execute the ansible for
all existing Deployments. This breaks the minor update workflow as
things are done out of order, and breaks the expectation that it is the
user who starts ansible executions as opposed to automatically.
Jira: OSPRH-8923
Signed-off-by: James Slagle [email protected]