Remove the deployed attribute from deployment #860
Merged
+0
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We reset the conditions and `deployed: false` for every reconcile now and code to check the deployed flag during reconcile is not relevant and dead code. We have also made the deployment spec immutable which won't allow for any changes to the spec. Signed-off-by: rabi <[email protected]>
fao89
approved these changes
Jun 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, rabi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test openstack-operator-build-deploy-kuttl |
1 similar comment
|
/test openstack-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit 3a6a837
into
openstack-k8s-operators:main
8 checks passed
|
Revert proposed at #970 due to https://issues.redhat.com/browse/OSPRH-8923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reset the conditions and
deployed: falsefor every reconcile now and code to check the deployed flag during reconcile is not relevant and dead code.We have also made the deployment spec immutable which won't allow for any changes to the spec.