Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tls] add the fqdn containing the cluster.local to the service certs #740

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Apr 9, 2024

Jira: OSPRH-3268

@openshift-ci openshift-ci bot requested review from abays and viroel April 9, 2024 15:27
@openshift-ci openshift-ci bot added the approved label Apr 9, 2024
@stuggi stuggi requested review from olliewalsh and removed request for viroel April 9, 2024 15:27
Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Apr 10, 2024
@stuggi
Copy link
Contributor Author

stuggi commented Apr 10, 2024

/test openstack-operator-build-deploy-kuttl

3 similar comments
@stuggi
Copy link
Contributor Author

stuggi commented Apr 10, 2024

/test openstack-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor Author

stuggi commented Apr 10, 2024

/test openstack-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor Author

stuggi commented Apr 11, 2024

/test openstack-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit f2b65a1 into openstack-k8s-operators:main Apr 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants