-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ONVDB client certificate for Octavia #730
Create ONVDB client certificate for Octavia #730
Conversation
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f04065a4e699450c9e06bc8d10f62e1a ❌ openstack-k8s-operators-content-provider FAILURE in 16m 36s |
CertName: fmt.Sprintf("%s-ovndbs", serviceName), | ||
Duration: nil, | ||
Hostnames: []string{ | ||
fmt.Sprintf("%s.%s.svc", serviceName, instance.Namespace), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a wildcard cert since the pod dns names are not predictable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some services like neutron not using the wildcard: https://github.com/openstack-k8s-operators/openstack-operator/blob/main/pkg/openstack/neutron.go#L73 (I based my code on it)
is it really useful here?
8628e0b
to
57faeb0
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/0d8c98ed70404724ad2ed42dc2e6d282 ❌ openstack-k8s-operators-content-provider FAILURE in 9m 35s |
57faeb0
to
7c1a97e
Compare
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
7c1a97e
to
2b33e51
Compare
The certificate is required by the Octavia OVN provider when TLS is enabled at the Pod level. It also bumps of the version of octavia-operator Jira: OSPRH-6065
2b33e51
to
bfd3eed
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/79111a8227bf4d8882c95102dd3abae7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 34m 32s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/d5f258121eef44588adb9641014b79d6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 50m 59s |
needs a rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gthiemonge, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
41031f2
into
openstack-k8s-operators:main
The certificate is required by the Octavia OVN provider when TLS is enabled at the Pod level.
Jira: OSPRH-6065