Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ONVDB client certificate for Octavia #730

Merged

Conversation

gthiemonge
Copy link
Contributor

@gthiemonge gthiemonge commented Apr 2, 2024

The certificate is required by the Octavia OVN provider when TLS is enabled at the Pod level.

Jira: OSPRH-6065

@openshift-ci openshift-ci bot requested review from abays and dprince April 2, 2024 07:14
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f04065a4e699450c9e06bc8d10f62e1a

openstack-k8s-operators-content-provider FAILURE in 16m 36s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

CertName: fmt.Sprintf("%s-ovndbs", serviceName),
Duration: nil,
Hostnames: []string{
fmt.Sprintf("%s.%s.svc", serviceName, instance.Namespace),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a wildcard cert since the pod dns names are not predictable.

Copy link
Contributor Author

@gthiemonge gthiemonge Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some services like neutron not using the wildcard: https://github.com/openstack-k8s-operators/openstack-operator/blob/main/pkg/openstack/neutron.go#L73 (I based my code on it)
is it really useful here?

pkg/openstack/octavia.go Outdated Show resolved Hide resolved
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0d8c98ed70404724ad2ed42dc2e6d282

openstack-k8s-operators-content-provider FAILURE in 9m 35s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 730,7c1a97ea0ece78ab35edde7067f3d8383902f512

The certificate is required by the Octavia OVN provider when TLS is
enabled at the Pod level.

It also bumps of the version of octavia-operator

Jira: OSPRH-6065
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/79111a8227bf4d8882c95102dd3abae7

✔️ openstack-k8s-operators-content-provider SUCCESS in 34m 32s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 8m 17s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 4s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 11m 26s
openstack-operator-tempest-multinode RETRY_LIMIT in 12m 42s

@weinimo
Copy link
Contributor

weinimo commented Apr 17, 2024

recheck
RETRY_LIMIT

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d5f258121eef44588adb9641014b79d6

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 50m 59s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 20s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 20s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 17m 00s
openstack-operator-tempest-multinode FAILURE in 1h 38m 30s

@stuggi
Copy link
Contributor

stuggi commented Apr 17, 2024

needs a rebase

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gthiemonge, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 41031f2 into openstack-k8s-operators:main Apr 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants