Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine Netmask from IP CIDR #1224

Closed
wants to merge 1 commit into from
Closed

Determine Netmask from IP CIDR #1224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/dataplane/baremetal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ func DeployBaremetalSet(
return fmt.Errorf("%s gateway is missing", dataplanev1.CtlPlaneNetwork)
}
baremetalSet.Spec.CtlplaneGateway = *res.Gateway
baremetalSet.Spec.CtlplaneNetmask = string(ipNet.Mask)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ctlplaneNetmask is not used at all atm. ctlplaneIP is in CIDR format[1] and that's used instead in openstack-baremetal-operator.

[1] https://github.com/openstack-k8s-operators/openstack-operator/blob/main/pkg/dataplane/baremetal.go#L87

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's remove it from baremetal-operator then, and that should solve this problem that I was trying to address. So we can just close this PR.

baremetalSet.Spec.BootstrapDNS = dnsAddresses
baremetalSet.Spec.DNSSearchDomains = []string{res.DNSDomain}
}
Expand Down
Loading