Determine Netmask from IP CIDR #1224
Conversation
Signed-off-by: Brendan Shephard <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test images |
| @@ -89,6 +89,7 @@ func DeployBaremetalSet( | |||
| return fmt.Errorf("%s gateway is missing", dataplanev1.CtlPlaneNetwork) | |||
| } | |||
| baremetalSet.Spec.CtlplaneGateway = *res.Gateway | |||
| baremetalSet.Spec.CtlplaneNetmask = string(ipNet.Mask) | |||
There was a problem hiding this comment.
I think ctlplaneNetmask is not used at all atm. ctlplaneIP is in CIDR format[1] and that's used instead in openstack-baremetal-operator.
There was a problem hiding this comment.
Ok, let's remove it from baremetal-operator then, and that should solve this problem that I was trying to address. So we can just close this PR.
jira: https://issues.redhat.com/browse/OSPRH-12303