Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with rabbitmq operator status check #993

Conversation

karelyatin
Copy link
Contributor

#986 broke kuttl tests as was checking for wrong deployment name as it's not similar to other openstack operators.

openstack-k8s-operators#986 broke
kuttl tests as was checking for wrong deployment name as it's not
similar to other openstack operators.
@openshift-ci openshift-ci bot requested review from cjeanner and fmount December 23, 2024 08:31
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karelyatin
Copy link
Contributor Author

/override rdoproject.org/github-check
somehow jobs results not posted back https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6d7468859a1946a9bf8e549212609c71

Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

@karelyatin: Overrode contexts on behalf of karelyatin: rdoproject.org/github-check

In response to this:

/override rdoproject.org/github-check
somehow jobs results not posted back https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6d7468859a1946a9bf8e549212609c71

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 209e1db into openstack-k8s-operators:main Dec 23, 2024
5 checks passed
@karelyatin karelyatin deleted the operator_status_rabbit branch December 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants