Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for running replicas for get-operator-status.sh #986

Merged

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Dec 19, 2024

We are eliminating CSV's for service operators when using openstack-operator. As such in order to check that all operators are running we should can check for replicas for the controller-manager deployments

@openshift-ci openshift-ci bot requested review from cjeanner and fao89 December 19, 2024 16:53
@abays
Copy link
Contributor

abays commented Dec 19, 2024

Also need to update this:

timeout ${TIMEOUT} bash -c 'until [ "$(bash ./get-operator-status.sh)" == "Succeeded" ]; do sleep 5; done'

We are eliminating CSV's for service operators when using
openstack-operator. As such in order to check that all operators are
running we should can check for replicas for the controller-manager
deployments
@dprince dprince force-pushed the operator_status_fix branch from 90b7c55 to 565f374 Compare December 19, 2024 17:09
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7b6c92f into openstack-k8s-operators:main Dec 19, 2024
5 checks passed
@karelyatin
Copy link
Contributor

karelyatin commented Dec 23, 2024

This broke kuttl jobs as failing now:-
`+ timeout 300s bash -c 'until [ "$(bash ./get-operator-status.sh)" == "Succeeded" ]; do sleep 5; done'

  • '[' -z openstack-operators ']'
  • '[' -z rabbitmq-cluster ']'
    ++ oc get -n openstack-operators deployment rabbitmq-cluster-operator-controller-manager -o json
    ++ jq -e .status.availableReplicas
    Error from server (NotFound): deployments.apps "rabbitmq-cluster-operator-controller-manager" not found
  • REPLICAS=
  • '[' '' '!=' 1 ']'
  • exit 1`

karelyatin added a commit to karelyatin/install_yamls that referenced this pull request Dec 23, 2024
openstack-k8s-operators#986 broke
kuttl tests as was checking for wrong deployment name as it's not
similar to other openstack operators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants