Improve envTest for validation webhooks #494
Conversation
| @@ -205,6 +198,11 @@ func (r *Glance) ValidateCreate() (admission.Warnings, error) { | |||
| return nil, errors.New("Invalid backend configuration detected") | |||
| } | |||
| } | |||
| // At creation time, if the CR has an invalid keystoneEndpoint value (that | |||
| // doesn't match with any defined backend), return an error. | |||
| if !r.Spec.isValidKeystoneEP() { | |||
There was a problem hiding this comment.
This function iterates over the API, no need to iterate multiple times, so I put it outside of the for loop.
| // At update time, if the CR has an invalid keystoneEndpoint set | ||
| // (e.g. an Edge GlanceAPI instance that can't be registered in keystone) | ||
| // return an error message | ||
| if !r.Spec.isValidKeystoneEP() { |
There was a problem hiding this comment.
same comment, we already iterate over the API within the function, no need to stay within an external for loop (that represents the same iteration!)
This patch fixes the isValidEndpoint function provided by the validation webhook and introduces envTests for Validation webhooks, that are one of the most important part of the operator. Signed-off-by: Francesco Pantano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, konan-abhi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test glance-operator-build-deploy-kuttl |
1 similar comment
|
/test glance-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit e5cff17
into
openstack-k8s-operators:main
This patch fixes the
isValidEndpointfunction provided by the validationwebhookand introducesenvTestsfor Validation webhooks that are one of the most important part of the operator.