-
Notifications
You must be signed in to change notification settings - Fork 38
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #494 from fmount/edge_sample_fix
Improve envTest for validation webhooks
- Loading branch information
Showing
5 changed files
with
191 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| /* | ||
| Copyright 2024. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| package functional | ||
|
|
||
| import ( | ||
| "errors" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" | ||
|
|
||
| k8s_errors "k8s.io/apimachinery/pkg/api/errors" | ||
| "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
| ) | ||
|
|
||
| var _ = Describe("Glance validation", func() { | ||
| It("webhooks reject the request - invalid keystoneEndpoint", func() { | ||
| // GlanceEmptySpec is used to provide a standard Glance CR where no | ||
| // field is customized: we can inject our parameters to test webhooks | ||
| spec := GetGlanceDefaultSpec() | ||
| spec["keystoneEndpoint"] = "foo" | ||
| raw := map[string]interface{}{ | ||
| "apiVersion": "glance.openstack.org/v1beta1", | ||
| "kind": "Glance", | ||
| "metadata": map[string]interface{}{ | ||
| "name": glanceTest.Instance.Name, | ||
| "namespace": glanceTest.Instance.Namespace, | ||
| }, | ||
| "spec": spec, | ||
| } | ||
| unstructuredObj := &unstructured.Unstructured{Object: raw} | ||
| _, err := controllerutil.CreateOrPatch( | ||
| ctx, k8sClient, unstructuredObj, func() error { return nil }) | ||
|
|
||
| Expect(err).Should(HaveOccurred()) | ||
| var statusError *k8s_errors.StatusError | ||
| Expect(errors.As(err, &statusError)).To(BeTrue()) | ||
| Expect(statusError.ErrStatus.Message).To( | ||
| ContainSubstring( | ||
| "KeystoneEndpoint is assigned to an invalid glanceAPI instance"), | ||
| ) | ||
| }) | ||
|
|
||
| It("webhooks reject the request - invalid backend", func() { | ||
| spec := GetGlanceDefaultSpec() | ||
|
|
||
| gapis := map[string]interface{}{ | ||
| "glanceAPIs": map[string]interface{}{ | ||
| "default": map[string]interface{}{ | ||
| "replicas": 1, | ||
| "type": "split", | ||
| }, | ||
| "edge1": map[string]interface{}{ | ||
| "replicas": 1, | ||
| "type": "edge", | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| spec["keystoneEndpoint"] = "edge1" | ||
| spec["glanceAPIs"] = gapis | ||
|
|
||
| raw := map[string]interface{}{ | ||
| "apiVersion": "glance.openstack.org/v1beta1", | ||
| "kind": "Glance", | ||
| "metadata": map[string]interface{}{ | ||
| "name": glanceTest.Instance.Name, | ||
| "namespace": glanceTest.Instance.Namespace, | ||
| }, | ||
| "spec": spec, | ||
| } | ||
| unstructuredObj := &unstructured.Unstructured{Object: raw} | ||
| _, err := controllerutil.CreateOrPatch( | ||
| ctx, k8sClient, unstructuredObj, func() error { return nil }) | ||
|
|
||
| Expect(err).Should(HaveOccurred()) | ||
| var statusError *k8s_errors.StatusError | ||
| Expect(errors.As(err, &statusError)).To(BeTrue()) | ||
| // Webhooks catch that no backend is set before even realize that an | ||
| // invalid endpoint has been set | ||
| Expect(statusError.ErrStatus.Message).To( | ||
| ContainSubstring( | ||
| "Invalid backend configuration detected"), | ||
| ) | ||
| }) | ||
|
|
||
| It("webhooks reject the request - invalid instance", func() { | ||
| spec := GetGlanceDefaultSpec() | ||
|
|
||
| gapis := map[string]interface{}{ | ||
| "edge2": map[string]interface{}{ | ||
| "replicas": 1, | ||
| "type": "edge", | ||
| // inject a valid Ceph backend | ||
| "customServiceConfig": GetDummyBackend(), | ||
| }, | ||
| "default": map[string]interface{}{ | ||
| "replicas": 1, | ||
| "type": "split", | ||
| // inject a valid Ceph backend | ||
| "customServiceConfig": GetDummyBackend(), | ||
| }, | ||
| "edge1": map[string]interface{}{ | ||
| "replicas": 1, | ||
| "type": "edge", | ||
| // inject a valid Ceph backend | ||
| "customServiceConfig": GetDummyBackend(), | ||
| }, | ||
| } | ||
| // Set the KeystoneEndpoint to the wrong instance | ||
| spec["keystoneEndpoint"] = "edge1" | ||
| // Deploy multiple GlanceAPIs | ||
| spec["glanceAPIs"] = gapis | ||
|
|
||
| raw := map[string]interface{}{ | ||
| "apiVersion": "glance.openstack.org/v1beta1", | ||
| "kind": "Glance", | ||
| "metadata": map[string]interface{}{ | ||
| "name": glanceTest.Instance.Name, | ||
| "namespace": glanceTest.Instance.Namespace, | ||
| }, | ||
| "spec": spec, | ||
| } | ||
| unstructuredObj := &unstructured.Unstructured{Object: raw} | ||
| _, err := controllerutil.CreateOrPatch( | ||
| ctx, k8sClient, unstructuredObj, func() error { return nil }) | ||
|
|
||
| Expect(err).Should(HaveOccurred()) | ||
| var statusError *k8s_errors.StatusError | ||
| Expect(errors.As(err, &statusError)).To(BeTrue()) | ||
| // We shouldn't fail again for the backend, but because the endpoint is | ||
| // not valid | ||
| Expect(statusError.ErrStatus.Message).To( | ||
| ContainSubstring( | ||
| "KeystoneEndpoint is assigned to an invalid glanceAPI instance"), | ||
| ) | ||
| }) | ||
| }) |