Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize api_distro to false on windows as layout doesn't change #3983

Merged
merged 3 commits into from
Dec 18, 2024
Merged

initialize api_distro to false on windows as layout doesn't change #3983

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
821daf8
initialize api_distro to false on windows as layout doesn't change be…
aymanhab Dec 14, 2024
785d0de
Merge branch 'main' into fix_matlab_configure_windows
aymanhab Dec 17, 2024
b0b8d84
Return api_distro as output
aymanhab Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Bindings/Java/Matlab/configureOpenSim.m.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ try
% This function returns all but the leaf element of the provided path.
openSimFolder = fileparts(openSimFolder);
end
api_distro = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but it would be clearer to initialize api_distro in uiGetOpenSimFolder and return it as an additional output.

% For this to be an OpenSim installation, there must be a buildinfo file.
buildInfoFile = fullfile(openSimFolder, '@CMAKE_INSTALL_SYSCONFDIR@', ...
'OpenSim_buildinfo.txt');
Expand Down
Loading