initialize api_distro to false on windows as layout doesn't change #3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween api and app
nickbianco
requested changes
Dec 17, 2024
| @@ -114,6 +114,7 @@ try | |||
| % This function returns all but the leaf element of the provided path. | |||
| openSimFolder = fileparts(openSimFolder); | |||
| end | |||
| api_distro = false; | |||
There was a problem hiding this comment.
Minor, but it would be clearer to initialize api_distro in uiGetOpenSimFolder and return it as an additional output.
|
ok, done @nickbianco feel free to review and/or test further. |
nickbianco
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aymanhab)
|
Thanks @nickbianco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3982
Brief summary of changes
initialize variable so available in all scopes
Testing I've completed
installed into matlab locally
Looking for feedback on...
CHANGELOG.md (choose one)
This change is