Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies of dependencies to lib #14

Closed
wants to merge 4 commits into from
Closed

Dependencies of dependencies to lib #14

wants to merge 4 commits into from

Conversation

AlbertoCasasOrtiz
Copy link
Collaborator

@AlbertoCasasOrtiz AlbertoCasasOrtiz commented Jun 25, 2022

This branch was not passing CI checks on Ubuntu and this pull request fixes it.

Brief summary of changes

While building opensim-core's dependencies, some required libraries were not copied to the lib folder (those libraries are dependencies of the dependencies, like ipopt, colpack or numps). I added some cp instructions to the script build.sh in order to copy them.

Testing I've completed

This has passed CI in my fork (for Ubuntu and Windows) and completed the conda build step in local.

Looking for feedback on...

A way to do the copy automatically while building the dependencies, instead of having to copy them manually in the script.

@AlbertoCasasOrtiz AlbertoCasasOrtiz mentioned this pull request Jun 27, 2022
@aymanhab aymanhab changed the base branch from master to master-with-moco June 27, 2022 17:39
@aymanhab
Copy link
Member

Thanks @AlbertoCasasOrtiz for working this out. Longer term we need to make this copying part of the installation process so that it works for plain API usage, conda, docker or any other derivative work. So, we'll leave this PR open and update the commit hash from opensim-core when ready.

Maintaining both opensim and opensim-moco conda packages in the same repo is a bit messy so I'm thinking of keeping a separate branch (master-with-moco) but keeping that in sync with master would be hard. Other thoughts, ideas?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants