-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread Safety Proposal (RM Ticket #218) #43
Changes from 1 commit
406c034
98afefb
5c87edb
9a59bc0
165fdac
ecf1760
9e96f22
f11baab
4e0fba6
daff54d
abbdce2
6e72c29
1d79d65
cc8a9a2
38aac8a
a194c42
60d4eaa
0e69425
be1d59d
5ff2fc6
5c4d937
d64061c
ddaca9c
31e4640
f93cde3
6539f0d
1feb8ee
24fa9c2
af1c027
f9a6961
36217c4
582b268
af503cc
e9e5c5a
d6945b6
030f66e
35c0097
967e059
36b9d95
28125ef
bcbd31d
0dc357c
65aa138
f6dcbf6
6f7d703
9703340
53da46e
137bfe9
721dc80
c1cbdf8
4bd6cf0
70a417f
b02669e
f824f99
6613904
e3588b7
b0a6e3b
b5202e8
3591b7c
948287f
fc2687d
9ae9899
2d8c789
3bbe016
73294b7
bb7ae09
b310e00
f9814df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,10 +19,9 @@ | |
\begin{tabular}{p{0.2\textwidth} | p{0.7\textwidth}} | ||
{} | ||
& | ||
{ Waits for a symmetric variable to be updated by a remote \ac{PE} \newtext{or the same | ||
\ac{PE} in the case of multi-threaded \openshmem{}}. Should be | ||
used when computation on the \newtext{calling thread} \oldtext{local \ac{PE}} cannot proceed without the value that | ||
the remote \newtext{thread or} \ac{PE} is to update.} \tabularnewline | ||
Waits for a symmetric variable to be updated by a remote \ac{PE}. Should be | ||
used when computation on the local \ac{PE} cannot proceed without the value that | ||
the remote \ac{PE} is to update. \tabularnewline | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are these curly braces removed? This edit appears to be unrelated to this proposal. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why were the braces removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was a part of various additions and deletions. I can add back. It seems to have impact There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it seems to have no impact. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, the curly braces are a bit odd. If you verified that the PDF is unchanged, then I'm ok with the change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The pdf looks fine. Also, some of the other items in the table doesn’t have curly braces. |
||
\hline | ||
\end{tabular} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the intended change didn't make it (replace remote by 'a' )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ... good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abouteiller Looking at the sentence, it seems to me it is better to leave the sentence as it is, since the reference is wrt to the diagram.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manjugv I think a local (i.e. a thread) may update the variable with an AMO/put
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree, that is reflected in the changes to shmem_wait. This text here is in reference only to the diagram.