-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread Safety Proposal (RM Ticket #218) #43
Merged
+213
−26
Merged
Changes from 1 commit
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
406c034
Adding Threads Intro
manjugv 98afefb
Adding Init Thread Interface
manjugv 5c87edb
Adding Query Thread Interface
manjugv 9a59bc0
Adding thread subsection
manjugv 165fdac
cleaning up intro text
manjugv ecf1760
Clean-up threads intro
manjugv 9e96f22
Cleanups: shmem_init_thread; edits - thread intro
manjugv f11baab
More edits to the text
manjugv 4e0fba6
Clarifying with an example the meaning of completion semantics
manjugv daff54d
Editing the listing of shmem_malloc/alloc routines
manjugv abbdce2
Fixing typo
manjugv 6e72c29
Adding Text - Explicitly calls out threads should complete communicai…
manjugv 1d79d65
Add serialized and unsupported thread modes
manjugv cc8a9a2
Text edit - cleanup
manjugv 38aac8a
Removing Fortran interfaces
manjugv a194c42
Add macros to function name; use lower case names
manjugv 60d4eaa
Add missing mode in description; minor text edit
manjugv 0e69425
Replacing textit with VAR and finalize->shmem\_finalize
manjugv be1d59d
addressing processes -> PE
manjugv 5ff2fc6
Removing -by all threads- in finalize
manjugv 5c4d937
FUNNELED mode text edit - make the main thread explicit
manjugv d64061c
Cleanup wait routine
manjugv ddaca9c
Reverting changes to synchronization model example
manjugv 31e4640
Explicitly say that shmem_init should not be called after shmem_init_…
manjugv f93cde3
Cleanup - make function names consistent
manjugv 6539f0d
minor edits
manjugv 1feb8ee
remote reference to remote write
manjugv 24fa9c2
minor edits
manjugv af1c027
Re-structuring OpenSHMEM modes
manjugv f9a6961
Expand description of thread semantics
manjugv 36217c4
Minor edits to thread description and shmem_init_thread interface des…
manjugv 582b268
Fix : Use macros for functions, variables, and constants
manjugv af503cc
Minor edits - macrofy function names
manjugv e9e5c5a
Addressing some of the Nick's comments
manjugv d6945b6
Fix : Use lower case in FUNC macro
manjugv 030f66e
Fix: Avoid using 'runnable'
manjugv 35c0097
Fixing a typo
manjugv 967e059
Fix: define main thread; remove reference to barrier being called dur…
manjugv 36b9d95
Add return code to shmem_init_thread; incorporating issue #70
manjugv 28125ef
Multithreaded changes to shmem_barrier_all
manjugv bcbd31d
Edit: redudant sentence
manjugv 0dc357c
Adding multithreading notes for shmem_quiet ; reflect May 2 WG discus…
manjugv 65aa138
Reworking shmem_quiet note for multithreaded PE; 10x Jim for feedback
manjugv f6dcbf6
Missing macro, line break error
manjugv 6f7d703
Addressing some of issues from WG meeting
manjugv 9703340
Addressing Spec Meeting Feedback: when program inited with shmem_init
manjugv 53da46e
Minor edits to shmem_quiet notes
manjugv 137bfe9
Minor edit
manjugv 721dc80
Fix : Whitespace
manjugv c1cbdf8
Rephrase the sentenc
manjugv 4bd6cf0
Replacing openshmem program with openshmem library
manjugv 70a417f
Removing reference to four levels in the description
manjugv b02669e
Adding change log for thread safety changes
manjugv f824f99
Editorial changes - Jim's request
manjugv 6613904
Remove old and new text highlighting
e3588b7
minor edits: openshmem{} -> openshmem
manjugv b0a6e3b
Rephrasing the sentence - shmem_init_thread
manjugv b5202e8
Merge branch 'osh_spec_next' into ticket-218
manjugv 3591b7c
hard wrap and minor edits to shmem_init_thread
manjugv 948287f
Minor edits: addressing @abouteiller comments
manjugv fc2687d
Minor formating fixes
manjugv 9ae9899
openshmem{} -> openshmem
manjugv 2d8c789
Minor edits: Jim's comments
manjugv 3bbe016
Whitespace fixes (only whitespace edits)
73294b7
Fix error merging change from PR #71
bb7ae09
None -> None. for consistency
b310e00
Fix labels for threads section
f9814df
Move threading section to follow library setup, etc.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
openshmem{} -> openshmem
commit 9ae989922d9963461182d10020c99feaef3c0320
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "or shmem_init_thread"
or substitute "\acp{PE} that initialized the \openshmem library"
or remove altogether? Isn't that precision redundant with the stated need for a OpenSHMEM program to call shmem_init explicitly since 1.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside this, 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence was not introduced in this ticket. But, this is a good fix and collectives chapter committee can handle this. Can you please make a note there ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence in question will be deleted by the contexts proposal. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #119 for this edit. How about those +1's?