OCPBUGS-16547: Bump machine-config-operator #966
Conversation
Update machine config operator to remove dependency on goproxy. Signed-off-by: Salvatore Daniele <[email protected]>
Signed-off-by: Salvatore Daniele <[email protected]>
Due to updating the machine config operator, we removed an indirect dependency on github.com/golang/glog. This package provides an init() method which sets a number of flags that we expect to be present [1]. To ensure compatability with the updates, we can explicitly add these flags with the klog.init() method [2]. It is better to include packages that are required to keep the API consistent explicitly. [1] https://github.com/golang/glog/blob/424d2337a5299a465c8a8228fc3ba4b1c28337a2/glog.go#L398-L404 [2] https://github.com/kubernetes/klog#:~:text=Use%20klog.InitFlags(nil)%20explicitly%20for%20initializing%20global%20flags%20as%20we%20no%20longer%20use%20init()%20method%20to%20register%20the%20flags Signed-off-by: Salvatore Daniele <[email protected]>
openshift-ci-robot
added
jira/valid-reference
|
@SalDaniele: This pull request references Jira Issue OCPBUGS-16547, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@SalDaniele: This pull request references Jira Issue OCPBUGS-16547, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@SalDaniele: This pull request references Jira Issue OCPBUGS-16547, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/retest ci/prow/security |
|
@SalDaniele: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ci/prow/security |
|
@SalDaniele: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@zeeke PTAL, last one :) |
|
/retest |
|
/lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler and qiowang721
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SalDaniele, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/override ci/prow/security |
|
@SalDaniele: Overrode contexts on behalf of SalDaniele: ci/prow/security In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@SalDaniele: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 96c2605
into
openshift:release-4.14
|
@SalDaniele: Jira Issue OCPBUGS-16547: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-16547 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-config-daemon |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-webhook |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-operator |
Backport of k8snetworkplumbingwg/sriov-network-operator#707