Update machine config operator #707

SalDaniele · 2024-06-04T20:38:22Z

Update machine config operator to remove dependency on goproxy.

go mod tidy && go mod vendor

github-actions · 2024-06-04T20:38:33Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-06-04T20:45:52Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

wizhaoredhat · 2024-06-04T20:52:46Z

LGTM

zeeke · 2024-06-05T07:30:40Z

CI is broken due to the webhook not able to start (logs)

2024-06-04T21:27:05.8888659Z ==== START logs for container webhook-server of pod sriov-network-operator/operator-webhook-9jvn9 ====
2024-06-04T21:27:05.8888829Z Error: unknown flag: --alsologtostderr
2024-06-04T21:27:05.8888907Z Usage:
2024-06-04T21:27:05.8889117Z   sriov-network-operator-webhook start [flags]
2024-06-04T21:27:05.8889127Z 
2024-06-04T21:27:05.8889207Z Flags:
2024-06-04T21:27:05.8889668Z       --enable-http2                  If HTTP/2 should be enabled for the metrics and webhook servers.
2024-06-04T21:27:05.8889876Z   -h, --help                          help for start
2024-06-04T21:27:05.8890277Z       --port int                      Secure port that the webhook listens on (default 443)
2024-06-04T21:27:05.8890991Z       --tls-cert-file string          File containing the default x509 Certificate for HTTPS. (CA cert, if any, concatenated after server cert).
2024-06-04T21:27:05.8891592Z       --tls-private-key-file string   File containing the default x509 private key matching --tls-cert-file.
2024-06-04T21:27:05.8891600Z 
2024-06-04T21:27:05.8891684Z Global Flags:
2024-06-04T21:27:05.8892792Z       --zap-devel                         Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error) (default true)
2024-06-04T21:27:05.8893207Z       --zap-encoder encoder               Zap log encoding (one of 'json' or 'console')
2024-06-04T21:27:05.8894288Z       --zap-log-level level               Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
2024-06-04T21:27:05.8894995Z       --zap-stacktrace-level level        Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
2024-06-04T21:27:05.8895774Z       --zap-time-encoding time-encoding   Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.
2024-06-04T21:27:05.8895781Z 
2024-06-04T21:27:05.8896242Z ==== END logs for container webhook-server of pod sriov-network-operator/operator-webhook-9jvn9 ====

any idea of how it happened? maybe one of the bumped dependency broke it?

SalDaniele · 2024-06-05T14:25:45Z

Hmm let me take a look. Its not obvious to me why bumping this dependencies would cause an unknown flag error to sriov-network-operator-webhook.

SalDaniele · 2024-06-05T15:26:23Z

It looks like some of the package updates are indeed responsible for the missing flags

Before upgrades:

Run Webhook Daemon which validates/mutates the Custom Resource of the SR-IoV Network Operator

Usage:
  sriov-network-operator-webhook [command]

Available Commands:
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  start       Starts Webhook Daemon

Flags:
      --alsologtostderr                   log to standard error as well as files
  -h, --help                              help for sriov-network-operator-webhook
      --log_backtrace_at traceLocations   when logging hits line file:N, emit a stack trace
      --log_dir string                    If non-empty, write log files in this directory
      --log_link string                   If non-empty, add symbolic links in this directory to the log files
      --logbuflevel int                   Buffer log messages logged at this level or lower (-1 means don't buffer; 0 means buffer INFO only; ...). Has limited applicability on non-prod platforms.
      --logtostderr                       log to standard error instead of files
      --stderrthreshold severityFlag      logs at or above this threshold go to stderr (default 2)
  -v, --v Level                           log level for V logs
      --vmodule vModuleFlag               comma-separated list of pattern=N settings for file-filtered logging
      --zap-devel                         Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error) (default true)
      --zap-encoder encoder               Zap log encoding (one of 'json' or 'console')
      --zap-log-level level               Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
      --zap-stacktrace-level level        Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
      --zap-time-encoding time-encoding   Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

After Upgrades:

Run Webhook Daemon which validates/mutates the Custom Resource of the SR-IoV Network Operator

Usage:
  sriov-network-operator-webhook [command]

Available Commands:
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  start       Starts Webhook Daemon

Flags:
  -h, --help                              help for sriov-network-operator-webhook
      --zap-devel                         Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error) (default true)
      --zap-encoder encoder               Zap log encoding (one of 'json' or 'console')
      --zap-log-level level               Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
      --zap-stacktrace-level level        Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
      --zap-time-encoding time-encoding   Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

Use "sriov-network-operator-webhook [command] --help" for more information about a command.

github-actions · 2024-06-06T12:51:29Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-06-06T13:04:45Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-06-06T13:26:13Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-06-06T13:50:19Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SalDaniele · 2024-06-06T15:32:45Z

@zeeke PTAL. Resolved the issues with the missing flags, we removed an indirect dependency on github.com/golang/glog by updating the machine config operator. This package provides an init() method which sets a number of flags such as alsologtostderr.

K8s test is passing now, I believe the OCP failure is unrelated to the PR

zeeke · 2024-06-06T15:56:40Z

@zeeke PTAL. Resolved the issues with the missing flags, we removed an indirect dependency on github.com/golang/glog by updating the machine config operator. This package provides an init() method which sets a number of flags such as alsologtostderr.

K8s test is passing now, I believe the OCP failure is unrelated to the PR

Thanks for going deep here. LGTM

SalDaniele · 2024-06-06T16:34:00Z

Looks like the ocp tests are failing still, I believe this is unrelated

+ internal_registry=image-registry.openshift-image-registry.svc:5000
++ jq '."image-registry.openshift-image-registry.svc:5000".password' registry-login.conf
+ pass='"***"'
+ podman login -u serviceaccount -p *** default-route-openshift-image-registry.apps.opr-ocp-2.lab --tls-verify=false
Error: logging into "default-route-openshift-image-registry.apps.opr-ocp-2.lab": invalid username/password
+ cleanup
+ kcli delete cluster opr-ocp-2 -y
opr-ocp-2-ctlplane-0 deleted on local!
opr-ocp-2-worker-0 deleted on local!
opr-ocp-2-worker-1 deleted on local!
opr-ocp-2-worker-2 deleted on local!
Deleting directory /root/.kcli/clusters/opr-ocp-2
+ kcli delete network opr-ocp-2 -y
Network opr-ocp-2 deleted
make: *** [Makefile:200: test-e2e-conformance-virtual-ocp-cluster-ci] Error 125

wizhaoredhat · 2024-06-07T05:39:15Z

@adrianchiris PTAL

SalDaniele · 2024-06-10T13:12:08Z

/test-all

Update machine config operator to remove dependency on goproxy. Signed-off-by: Salvatore Daniele <[email protected]>

Signed-off-by: Salvatore Daniele <[email protected]>

Due to updating the machine config operator, we removed an indirect dependency on github.com/golang/glog. This package provides an init() method which sets a number of flags that we expect to be present [1]. To ensure compatability with the updates, we can explicitly add these flags with the klog.init() method [2]. It is better to include packages that are required to keep the API consistent explicitly. [1] https://github.com/golang/glog/blob/424d2337a5299a465c8a8228fc3ba4b1c28337a2/glog.go#L398-L404 [2] https://github.com/kubernetes/klog#:~:text=Use%20klog.InitFlags(nil)%20explicitly%20for%20initializing%20global%20flags%20as%20we%20no%20longer%20use%20init()%20method%20to%20register%20the%20flags Signed-off-by: Salvatore Daniele <[email protected]>

github-actions · 2024-06-10T18:21:10Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SalDaniele · 2024-06-11T15:00:06Z

Hi @zeeke any insights into why the OCP CI test is failing?

SalDaniele · 2024-06-14T14:34:49Z

/test-all

bn222 · 2024-06-17T14:47:58Z

/override Test SR-IOV Operator / ocp (pull_request)

bn222 · 2024-06-17T14:48:08Z

LGTM

bn222 · 2024-06-17T14:48:23Z

@ykulazhenkov can you PTAL?

SalDaniele force-pushed the OCPBUGS-16547 branch from efdeb66 to 803af4d Compare June 4, 2024 20:45

SalDaniele force-pushed the OCPBUGS-16547 branch from f0508eb to b84e94f Compare June 6, 2024 13:04

SalDaniele force-pushed the OCPBUGS-16547 branch from b84e94f to 833d570 Compare June 6, 2024 13:26

SalDaniele force-pushed the OCPBUGS-16547 branch from 833d570 to 1d99976 Compare June 6, 2024 13:50

zeeke approved these changes Jun 6, 2024

View reviewed changes

SalDaniele added 3 commits June 10, 2024 14:19

Update machine config operator

37fac38

Update machine config operator to remove dependency on goproxy. Signed-off-by: Salvatore Daniele <[email protected]>

go mod vendor

be64d74

Signed-off-by: Salvatore Daniele <[email protected]>

SalDaniele force-pushed the OCPBUGS-16547 branch from 1d99976 to 98277ec Compare June 10, 2024 18:20

Eoghan1232 approved these changes Jun 17, 2024

View reviewed changes

bn222 merged commit ddb57f3 into k8snetworkplumbingwg:master Jun 17, 2024
12 of 13 checks passed

SalDaniele mentioned this pull request Jun 28, 2024

OCPBUGS-36336: Bump machine-config-operator openshift/sriov-network-operator#947

Merged

This was referenced Jul 10, 2024

OCPBUGS-36335: Bump machine-config-operator openshift/sriov-network-operator#962

Merged

OCPBUGS-16547: Bump machine-config-operator openshift/sriov-network-operator#966

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update machine config operator #707

Update machine config operator #707

SalDaniele commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

wizhaoredhat commented Jun 4, 2024

zeeke commented Jun 5, 2024

SalDaniele commented Jun 5, 2024

SalDaniele commented Jun 5, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

SalDaniele commented Jun 6, 2024

zeeke commented Jun 6, 2024

SalDaniele commented Jun 6, 2024

wizhaoredhat commented Jun 7, 2024

SalDaniele commented Jun 10, 2024

github-actions bot commented Jun 10, 2024

SalDaniele commented Jun 11, 2024

SalDaniele commented Jun 14, 2024

bn222 commented Jun 17, 2024

bn222 commented Jun 17, 2024

bn222 commented Jun 17, 2024

Update machine config operator #707

Update machine config operator #707

Conversation

SalDaniele commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

wizhaoredhat commented Jun 4, 2024

zeeke commented Jun 5, 2024

SalDaniele commented Jun 5, 2024

SalDaniele commented Jun 5, 2024 • edited Loading

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

SalDaniele commented Jun 6, 2024

zeeke commented Jun 6, 2024

SalDaniele commented Jun 6, 2024

wizhaoredhat commented Jun 7, 2024

SalDaniele commented Jun 10, 2024

github-actions bot commented Jun 10, 2024

SalDaniele commented Jun 11, 2024

SalDaniele commented Jun 14, 2024

bn222 commented Jun 17, 2024

bn222 commented Jun 17, 2024

bn222 commented Jun 17, 2024

SalDaniele commented Jun 5, 2024 •

edited

Loading