Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sriov-network-operator_configmap.yaml #674

Closed
wants to merge 1 commit into from
Closed

Update sriov-network-operator_configmap.yaml #674

wants to merge 1 commit into from

Conversation

relyt0925
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from fabrizio8 and fepan June 30, 2022 19:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: relyt0925
To complete the pull request process, please assign dougbtv after the PR has been reviewed.
You can assign the PR to them by writing /assign @dougbtv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@relyt0925: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cgoncalves
cgoncalves suggested changes Jul 5, 2022
View reviewed changes
config/manifests/bases/sriov-network-operator_configmap.yaml
@@ -6,6 +6,7 @@ data:
Broadcom_bnxt_en_BCM57414_NetXtreme-E: "14e4 16d7 16c1"
Broadcom_bnxt_en_BCM57508_NetXtreme-E: "14e4 1750 1806"
Intel_i40e_XXV710: "8086 158a 154c"
Intel_i40e_X710_X557_AT_10G: "8086 1589 154c"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This NIC is not listed as supported upstream. It probably should first be added there and then brought into OpenShift. See k8snetworkplumbingwg/sriov-network-operator@37b62c5 as an example.

Also, officially supporting this NIC in OpenShift probably requires coordination with QE, Docs, PM, etc teams.

@SchSeba
Copy link
Contributor

SchSeba commented Jul 5, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2022
@relyt0925
Copy link
Contributor Author

sounds good:
k8snetworkplumbingwg/sriov-network-operator#332

Will close this for now though

@relyt0925 relyt0925 closed this Jul 9, 2022
SchSeba added a commit to SchSeba/sriov-network-operator that referenced this pull request Apr 9, 2024
@SchSeba
Merge pull request openshift#674 from SchSeba/documentation_update
2d2e5a4 
Documentation update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgoncalves cgoncalves cgoncalves requested changes

@fabrizio8 fabrizio8 Awaiting requested review from fabrizio8

@fepan fepan Awaiting requested review from fepan

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@relyt0925 @SchSeba @cgoncalves