Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Intel X557 Family #332

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

relyt0925
Copy link
Contributor

The Intel Ethernet Connection X557 family is utilized in IBM Cloud bare metals. This adds support for being able to utilize SR-IOV in IBM Cloud when the bare metals have those ethernet cards.

@github-actions
Copy link

github-actions bot commented Jul 9, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Copy link
Contributor

@cgoncalves cgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Just a question on feature supportability.

@@ -5,6 +5,7 @@ The following SR-IOV capable hardware is supported with sriov-network-operator:
| Model | Vendor ID | Device ID |
| ------------------------ | --------- | --------- |
| Intel XXV710 Family | 8086 | 158b |
| Intel X557 Family | 8086 | 1589 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a second table below in the "Supported features per hardware" section. Would you be able to share what is working for you? I think "SR-IOV Kernel" and "SR-IOV DPDK" work fine but input from you would be great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea! Absolutely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Copy link
Contributor

@cgoncalves cgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@SchSeba
Copy link
Collaborator

SchSeba commented Jul 13, 2022

@Eoghan1232 @eoghanlawless can you please have a look?

Copy link
Collaborator

@eoghanlawless eoghanlawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris
Copy link
Collaborator

Greetings :) and thx for adding support for new hardware !

for adding a new hardware we have defined a process:
https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/doc/supported-hardware.md#initial-support

missing just the issue creation + updating with what was tested in the issue.
we already have folks from intel involved in the project so "contact person" will not be needed.

Also could you reformat commit message, first line after header is too long

Thanks !

@relyt0925
Copy link
Contributor Author

Here is the issue @adrianchiris
#343

And commit message reformatted.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2722484234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 15.726%

Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 67.33%
Totals Coverage Status
Change from base Build 2691407340: 0.1%
Covered Lines: 1153
Relevant Lines: 7332

💛 - Coveralls

Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Linter just hit timeout. as there are no code changes its not really relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants